[Ingest Manager ] prepend kibana asset ids with package name

[neptunian]

#65035

The kibana assets installed by the Ingest Manager could conflict with ones with the same ids installed by Beats. This change will keep separate versions by modifying the ids of the assets in the Ingest Manager, as well as the references to ids in Dashboard assets, before installing

Changes

• prepends the id of each installed kibana asset with the package name
• prepends the id of each asset the asset references (in the asset's references property)
• only asset ids of type dashboard, visualization, search, and map are modified

Test

• restart ES
• resfresh kibana in the browser
• view saved objects of any assets and see that ones belong to the package installed (by default, system and endpoint) are prepended with the package name, eg: http://localhost:5601/ssg/api/saved_objects/_find?fields=type&type=dashboard).
• view saved objects of epm-package and see it references the correct modified ids (eg http://localhost:5601/ssg/api/saved_objects/_find?fields=installed&type=epm-packages)
• In Kibana Navigate to Dashboards, Visualize, Maps, or Search and there should be a list of the assets with no errors. Clicking on the assets should appear and be reflected in the browser url:

- install a package and repeat

[elasticmachine]

Pinging @elastic/ingest-management (Team:Ingest Management)

[neptunian]

@elasticmachine merge upstream

[ruflin]

@neptunian Please make sure to test at least the dashboards of the system package that they still work. We have also some links in this dashboard which might break (I'm pretty sure they will). But for these we should update the package. Please have a conversation with @fearful-symmetry about it.

[jfsiii]

I haven't run this locally or thought about all the interactions, but the code LGTM.

I appreciate pulling the related code into a new file.

[neptunian]

Things seem to be working right but I missed that the links don't work. The links are in these markdown visualizations: https://github.com/elastic/integrations/blob/master/packages/nginx/kibana/visualization/97109780-a2a5-11e7-928f-5dbe6f6f5519-ecs.json#L14
It's possible to handle in the Ingest Management side, but I'm not sure what @ruflin has in mind for changing it on the package side.

[ruflin]

@neptunian We should not handle the links on the Ingest Management side as these are basically a hack and hopefully going away in the future.

[neptunian]

Okay. Looks like they exist in netflow, nginx, and system packages.

[neptunian]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 8efd0ae

Build metrics

✅ unchanged

History

• 💚 Build #58295 succeeded b13f8db
• 💚 Build #58258 succeeded cce757d
• 💚 Build #58070 succeeded 531cd25
• 💔 Build #58029 failed c6329a9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[neptunian]

@jfsiii I made those changes you asked for. Can you look again? Thanks!