[functional tests] test url field formatter on dashboard and discover #70736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v7.9.0
v8.0.0
v7.8.1
release_note:skip
|
Pinging @elastic/kibana-qa (Team:QA) |
bhavyarm
approved these changes
Jul 3, 2020
| }); | ||
| await common.navigateToApp('settings'); | ||
| await settings.clickKibanaIndexPatterns(); | ||
| await settings.clickIndexPatternLogstash(); |
There was a problem hiding this comment.
Should this be a separate test - while you set a field value to URL? Probably just a nit on my side? I am fine with it being in before part.
There was a problem hiding this comment.
I put to before because it is required by both follow-up tests. We actually do not test anything here, but update field for the tests
| await dashboard.loadSavedDashboard('dashboard with everything'); | ||
| await dashboard.waitForRenderComplete(); | ||
| const fieldLink = await visChart.getFieldLinkInVisTable(`${fieldName}: Descending`, 1); | ||
| await clickFieldAndCheckUrl(fieldLink); |
There was a problem hiding this comment.
Can't really see this part while executing (it goes really fast) but the logic looks good.
There was a problem hiding this comment.
yes, it is really fast but it does what it needs: click link, check that new tab is opened, gets url and verifies it, closes the tab.
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 3, 2020
…elastic#70736) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 3, 2020
…elastic#70736) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* master: [APM-UI] e2e speed up build (elastic#70704) skip flaky suite (elastic#70764) skip flaky suite (elastic#70762) [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752) [functional tests] test url field formatter on dashboard and discover (elastic#70736) logout from transform_poweruser user in after method of transform tests (elastic#70644) [SECURITY] Bug fix for topN on draggables (elastic#70450) [Logs UI] Reorganise log rate anomaly table (elastic#69516) Update dependency @elastic/charts to v19.7.0 (elastic#69791) Add googlecloud metricbeat module to Kibana Home (elastic#70652) [Logs UI] Logs overview queries for the observability dashboard (elastic#70413) [Lens] Fitting functions (elastic#69820)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* master: [APM-UI] e2e speed up build (elastic#70704) skip flaky suite (elastic#70764) skip flaky suite (elastic#70762) [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752) [functional tests] test url field formatter on dashboard and discover (elastic#70736) logout from transform_poweruser user in after method of transform tests (elastic#70644) [SECURITY] Bug fix for topN on draggables (elastic#70450) [Logs UI] Reorganise log rate anomaly table (elastic#69516) Update dependency @elastic/charts to v19.7.0 (elastic#69791) Add googlecloud metricbeat module to Kibana Home (elastic#70652) [Logs UI] Logs overview queries for the observability dashboard (elastic#70413)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* actions/feature: fixed type errors [APM-UI] e2e speed up build (elastic#70704) skip flaky suite (elastic#70764) skip flaky suite (elastic#70762) [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752) [functional tests] test url field formatter on dashboard and discover (elastic#70736) logout from transform_poweruser user in after method of transform tests (elastic#70644) [SECURITY] Bug fix for topN on draggables (elastic#70450) [Logs UI] Reorganise log rate anomaly table (elastic#69516) Update dependency @elastic/charts to v19.7.0 (elastic#69791) Add googlecloud metricbeat module to Kibana Home (elastic#70652) [Logs UI] Logs overview queries for the observability dashboard (elastic#70413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test covers regression #35235
Flaky test runner 30x https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/558/