-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM Dashboard] New rum services api to replace usage of get services API #70746
[RUM Dashboard] New rum services api to replace usage of get services API #70746
Conversation
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but I haven't run it yet.
This is a new thing, but we would like like to have all new API endpoints covered by a very simple APM integration test. Could you please add one for this endpoint? Let me know if you run into any problems.
@smith added a simple test for new API |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should allow creation of lens visualizationsStandard Out
Stack Trace
Build metrics
History
To update your PR or re-run it, just comment with: |
* master: [RUM Dashboard] New rum services api to replace usage of get services API (elastic#70746) fix: remove only consecutive ticks in TSVB (elastic#70981) [Functional test] Increase the timeout on opening a saved visualization (elastic#70952) [ML] Transforms/DFA: Refactor list action buttons so modals won't unmount after button click. (elastic#70555) [Functional test] Add retry for dashboard save (elastic#70950)
Summary
RUM dashboard page is using APM services api, which is really slow, since it's getting way more than just service name.
On rum page we only need rum services name, so this PR adds a new API which get's rum services name in a simple query. This usually takes few seconds.
Also using
For histogram to improve query performance for histograms.
Also fixed
transaction.duration.us
value from micro sec to secs.