Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page #70874

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Jul 6, 2020

Summary

When a user is looking at a Package Configuration (previously known as Datasource) in Ingest Management for Endpoint, and clicks the Edit Policy button, they will now be redirected back to the Ingest page from where they originated when either the Cancel button is clicked in the Endpoint Policy Details page, or a successful Save is done.

emt-509-insgest-endpoint-ingest-round-trip

In addition:

  • Added an dispatch action to the unmounting of the sub-plugins in order to ensure that proper state handling (ex. resetting) is handled when navigating to another Kibana App (ex. via navigateToApp()). This is necessary because the redux Store is persisted across plugin unmount lifecycles.

Checklist

Delete any items that are not applicable to this PR.

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.9.0 labels Jul 6, 2020
@paul-tavares paul-tavares self-assigned this Jul 6, 2020
@paul-tavares paul-tavares marked this pull request as ready for review July 7, 2020 16:05
@paul-tavares paul-tavares requested review from a team as code owners July 7, 2020 16:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@paul-tavares paul-tavares merged commit e99974d into elastic:master Jul 7, 2020
@paul-tavares paul-tavares deleted the task/EMT-509-round-trip-to-ingest-for-ds branch July 7, 2020 20:55
paul-tavares added a commit to paul-tavares/kibana that referenced this pull request Jul 7, 2020
…nitiates Edit Policy from Datasource Edit page (elastic#70874)

* allow Policy Details to support route state
* Functional Tests cases that cover ingest navigation
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 8, 2020
* master: (36 commits)
  fixed api url in example plugin (elastic#70934)
  [data.search.aggs]: Remove remaining client dependencies (elastic#70251)
  [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998)
  [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639)
  [SIEM][Detection Engine][Lists] Adds additional data types to value based lists
  [SIEM][Detection Engine][Lists] Removes feature flag for lists
  [APM] Show license callout in ML settings (elastic#70959)
  Migrate service settings test to jest (elastic#70992)
  [APM] Add cloud attributes to data telemetry (elastic#71008)
  Fix breadcrumb on panels for visibility / round corners (elastic#71010)
  Improve search typescript (elastic#69333)
  [savedObjects field count] run in baseline job (elastic#70999)
  [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988)
  [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874)
  [APM] Add API tests (elastic#70740)
  [Security Solution][Exceptions] - Tie server and client code together (elastic#70918)
  [Audit Logging] Add AuditTrail service (elastic#69278)
  [Usage Collection] Ensure no type duplicates (elastic#70946)
  [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958)
  [CI] Add pipeline task queue framework and merge workers into one (elastic#64011)
  ...
paul-tavares added a commit that referenced this pull request Jul 8, 2020
…nitiates Edit Policy from Datasource Edit page (#70874) (#71015)

* allow Policy Details to support route state
* Functional Tests cases that cover ingest navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants