-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Improve saved queries reload functional test #70957
Merged
kertal
merged 5 commits into
elastic:master
from
kertal:kertal-pr-2020-07-07-discover-harden-saved-queries-functional
Jul 9, 2020
Merged
[Discover] Improve saved queries reload functional test #70957
kertal
merged 5 commits into
elastic:master
from
kertal:kertal-pr-2020-07-07-discover-harden-saved-queries-functional
Jul 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@elasticmachine merge upstream |
…-queries-functional
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
…-queries-functional
@elasticmachine merge upstream |
…-queries-functional
@elasticmachine merge upstream |
…-queries-functional
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/visualize/_tsvb_chart·ts.visualize app visual builder switch index patterns should be able to switch between index patternsStandard Out
Stack Trace
Build metrics
History
To update your PR or re-run it, just comment with: |
dmlemeshko
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 9, 2020
kertal
added a commit
that referenced
this pull request
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Discover
Discover Application
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a retry to testing of
preserves the currently loaded query when the page is reloaded
at a line that failed in a flaky way in cloud tests. Done to prevent this occacional error, that I could reproduce with the flaky test runner in cloud (3 of 42 runs), and running with this fix, it was stable.Fixes #63029
Checklist