[Metrics UI] Fix Alert Preview Error design #71005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
Feature:Alerting
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
hbharding
reviewed
Jul 9, 2020
| <EuiSpacer size={'s'} /> | ||
| <EuiAccordion | ||
| id="alertErrorDetailsAccordion" | ||
| buttonContent={i18n.translate( |
There was a problem hiding this comment.
Change buttonContent so that it uses <EuiText size="s"> so that it matches the font size of other text in the callout
| } | ||
| )} | ||
| > | ||
| <EuiCodeBlock>{previewError.body.message}</EuiCodeBlock> |
There was a problem hiding this comment.
Add <EuiSpacer size={'s'} /> before the codeblock so that there is space between the codeblock and accordion toggle. You may need to wrap this in a fragment.
|
@hbharding Updated
|
…nto 70505-preview-error-fix
|
Thanks @Zacqary LGTM! |
hbharding
approved these changes
Jul 9, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
phillipb
approved these changes
Jul 20, 2020
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Zacqary
added a commit
that referenced
this pull request
Jul 20, 2020
Zacqary
added a commit
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70505
Replaces the modal-inside-a-modal design for the Alert Preview Error with an accordion.
Consulted with @hbharding on this design/text
Checklist