Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Improve Discover histogram time range tests #71056

Merged
merged 5 commits into from
Jul 9, 2020
Merged

[Discover] Improve Discover histogram time range tests #71056

merged 5 commits into from
Jul 9, 2020

Conversation

kertal
Copy link
Member

@kertal kertal commented Jul 8, 2020

Summary

Adding more stability to Discover histogram test to prevent flakiness.

Fixes #55798

Checklist

@kertal kertal self-assigned this Jul 8, 2020
@kertal kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure :KibanaApp/fix-it-week v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 8, 2020
@kertal
Copy link
Member Author

kertal commented Jul 8, 2020

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Jul 9, 2020

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Jul 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal marked this pull request as ready for review July 9, 2020 11:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

dmlemeshko
dmlemeshko approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kertal kertal merged commit 216ef47 into elastic:master Jul 9, 2020
@kertal kertal mentioned this pull request Jul 9, 2020
Merged
kertal added a commit to kertal/kibana that referenced this pull request Jul 9, 2020
@kertal @elasticmachine
[Discover] Improve Discover histogram time range tests (elastic#71056)
c3d8061 
* Improve Discover histogram tests

* Use includes function to find a string

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kertal kertal mentioned this pull request Jul 9, 2020
Closed
kertal added a commit that referenced this pull request Jul 9, 2020
@kertal
[Discover] Improve Discover histogram time range tests (#71056) (#71232)
bbe761f
@kertal kertal added the Feature:Discover Discover Application label Jul 11, 2020
@spalger spalger mentioned this pull request Jul 20, 2020
Merged
2 tasks
@kertal kertal added the v6.8.12 label Jul 30, 2020
@kertal kertal mentioned this pull request Jul 30, 2020
Merged
kertal added a commit to kertal/kibana that referenced this pull request Jul 30, 2020
@kertal
[Discover] Improve Discover histogram time range tests (elastic#71056)
310779f 
* Improve Discover histogram tests

* Use includes function to find a string

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	test/functional/apps/discover/_discover.js
kertal added a commit that referenced this pull request Jul 30, 2020
@kertal
[6.8] [Discover] Unskip Discover histogram time range test (#71056) (#…
114c96c 
…73771)

- Adaption of expected the time range when the histogram was brushed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@liza-mae liza-mae Awaiting requested review from liza-mae

Assignees

@kertal kertal

Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.8.12 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@kertal @kibanamachine @elasticmachine @dmlemeshko