Convert vega tests to jest #71073

DianaDerevyankina · 2020-07-08T11:11:45Z

Part of #57813

Summary

Converted vega tests to jest and removed old ones from legacy.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

Part of elastic#57813

src/plugins/vis_type_vega/public/vega_map_test.json

DianaDerevyankina · 2020-07-09T10:00:57Z

@elasticmachine merge upstream

elasticmachine · 2020-07-09T10:00:58Z

user doesn't have permission to update head repository

alexwizp · 2020-07-09T11:41:45Z

@elasticmachine merge upstream

elasticmachine · 2020-07-09T11:41:46Z

user doesn't have permission to update head repository

alexwizp · 2020-07-13T09:28:52Z

@elasticmachine merge upstream

elasticmachine · 2020-07-13T09:28:53Z

user doesn't have permission to update head repository

alexwizp · 2020-07-13T14:00:23Z

@elasticmachine merge upstream

elasticmachine · 2020-07-13T14:00:25Z

user doesn't have permission to update head repository

elasticmachine · 2020-07-13T14:00:55Z

Pinging @elastic/kibana-app (Team:KibanaApp)

src/plugins/vis_type_vega/public/vega_type.ts

VladLasitsa

LGTM!

sulemanof

I wouldn't use the __test__ folder name for jest test utils, as this is reserved folder name for karma/mocha env. You could use test or test_utils instead

sulemanof · 2020-07-14T10:34:36Z

src/plugins/vis_type_vega/public/vega_visualization.test.js

+ vegaVisualizationDependencies = {
+ core: {
+ uiSettings: coreStart.uiSettings,
+ },
+ plugins: {
+ data: {
+ query: {
+ timefilter: {
+ timefilter: {},
+ },
+ },
+ },
+ },
+ };


According to TS VegaVisualizationDependencies seems that right implementation of this mock is:

Suggested change

vegaVisualizationDependencies = {

core: {

uiSettings: coreStart.uiSettings,

},

plugins: {

data: {

query: {

timefilter: {

timefilter: {},

},

},

},

},

};

vegaVisualizationDependencies = {

core: coreMock.createSetup(),

plugins: {

data: dataPluginMock.createSetupContract()

},

};

This will help to avoid TS errors when moving to typescript (if it will)

sulemanof · 2020-07-14T10:43:02Z

I noticed there is the src/plugins/vis_type_vega/public/__mocks__ folder, which seems doesn't have any links on it in the existing kibana codebase. I bet these are mocks for legacy implementation and it has been just left during the migration.
Could you please check it and remove if unnecessary?

kibanamachine · 2020-07-14T13:31:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ebdd4d4

Build metrics

✅ unchanged

History

💚 Build #61293 succeeded 866bfe3
💚 Build #60834 succeeded d25d1a8
💔 Build #60780 failed 10ab256
💔 Build #60605 failed d107138
💔 Build #60584 failed e7bed7c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sulemanof

LGTM

stratoula

LGTM 🍰

* Convert vega tests to jest Part of elastic#57813 * Remove unused config * Move assets to __test__ folder and remove unnecessary code * clenup * cleanup * Revert default.spec.hjson file and mock default_spec * Refactor some code Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

* Convert vega tests to jest Part of #57813 * Remove unused config * Move assets to __test__ folder and remove unnecessary code * clenup * cleanup * Revert default.spec.hjson file and mock default_spec * Refactor some code Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

Convert vega tests to jest

cea066e

Part of elastic#57813

DianaDerevyankina added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.9.0 labels Jul 8, 2020

DianaDerevyankina requested review from VladLasitsa, alexwizp and sulemanof July 8, 2020 11:11

DianaDerevyankina self-assigned this Jul 8, 2020

Remove unused config

99e8941

alexwizp reviewed Jul 8, 2020

View reviewed changes

src/plugins/vis_type_vega/public/vega_map_test.json Outdated Show resolved Hide resolved

DianaDerevyankina added 2 commits July 9, 2020 08:53

Merge branch 'DianaDerevyankina' into Diana/57813-vega

ce759ca

Move assets to __test__ folder and remove unnecessary code

687e97c

alexwizp requested review from flash1293 and stratoula July 9, 2020 11:42

Merge branch 'DianaDerevyankina' into Diana/57813-vega

e9e5e81

DianaDerevyankina added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jul 9, 2020

DianaDerevyankina added 3 commits July 9, 2020 17:41

Merge branch 'DianaDerevyankina' into Diana/57813-vega

e5202d4

Merge branch 'DianaDerevyankina' into Diana/57813-vega

e7bed7c

Merge branch 'DianaDerevyankina' into Diana/57813-vega

d107138

alexwizp added 3 commits July 13, 2020 12:30

Merge remote-tracking branch 'upstream/master' into Diana/57813-vega

b5a367e

clenup

10ab256

cleanup

d25d1a8

alexwizp marked this pull request as ready for review July 13, 2020 14:00

alexwizp requested a review from a team July 13, 2020 14:00

timroes mentioned this pull request Jul 14, 2020

Bringing Vega out of experimental #21721

Closed

20 tasks

alexwizp reviewed Jul 14, 2020

View reviewed changes

src/plugins/vis_type_vega/public/vega_type.ts Outdated Show resolved Hide resolved

Merge branch 'DianaDerevyankina' into Diana/57813-vega

dbc03f8

VladLasitsa approved these changes Jul 14, 2020

View reviewed changes

Revert default.spec.hjson file and mock default_spec

866bfe3

sulemanof reviewed Jul 14, 2020

View reviewed changes

Refactor some code

ebdd4d4

sulemanof approved these changes Jul 14, 2020

View reviewed changes

stratoula approved these changes Jul 14, 2020

View reviewed changes

alexwizp approved these changes Jul 14, 2020

View reviewed changes

DianaDerevyankina merged commit 7d57be6 into elastic:master Jul 14, 2020

DianaDerevyankina mentioned this pull request Jul 14, 2020

[7.x] Convert vega tests to jest (#71073) #71668

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert vega tests to jest #71073

Convert vega tests to jest #71073

DianaDerevyankina commented Jul 8, 2020

DianaDerevyankina commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

alexwizp commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

alexwizp commented Jul 13, 2020

elasticmachine commented Jul 13, 2020

alexwizp commented Jul 13, 2020

elasticmachine commented Jul 13, 2020

elasticmachine commented Jul 13, 2020

VladLasitsa left a comment

sulemanof left a comment

sulemanof Jul 14, 2020 •

edited

Loading

sulemanof commented Jul 14, 2020

kibanamachine commented Jul 14, 2020

sulemanof left a comment

stratoula left a comment

Convert vega tests to jest #71073

Convert vega tests to jest #71073

Conversation

DianaDerevyankina commented Jul 8, 2020

Summary

Checklist

For maintainers

DianaDerevyankina commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

alexwizp commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

alexwizp commented Jul 13, 2020

elasticmachine commented Jul 13, 2020

alexwizp commented Jul 13, 2020

elasticmachine commented Jul 13, 2020

elasticmachine commented Jul 13, 2020

VladLasitsa left a comment

Choose a reason for hiding this comment

sulemanof left a comment

Choose a reason for hiding this comment

sulemanof Jul 14, 2020 • edited Loading

Choose a reason for hiding this comment

sulemanof commented Jul 14, 2020

kibanamachine commented Jul 14, 2020

💚 Build Succeeded

Build metrics

History

sulemanof left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

sulemanof Jul 14, 2020 •

edited

Loading