Dashboard add or update panel #71130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
added
Feature:Dashboard
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
7 tasks
majagrubic
reviewed
Jul 9, 2020
| @@ -40,6 +40,7 @@ export function isEmbeddableEditorState(state: unknown): state is EmbeddableEdit | |||
| export interface EmbeddablePackageByReferenceState { | |||
| type: string; | |||
| id: string; | |||
| embeddableIdToReplace?: string; | |||
There was a problem hiding this comment.
This doesn't have to go in this PR, but doesn't hurt. IMHO my opinion it would be better called just embeddableId, but as you wish.
There was a problem hiding this comment.
I will remove it from this PR, since it's no longer used. That key is actually just a workaround, specifically for removing the 'by value' embeddable after it has been added to the library. Once #70381 is fixed it should definitely be renamed embeddableId.
majagrubic
approved these changes
Jul 9, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 9, 2020
Added a standard method for adding or replacing a panel on a dashboard.
ThomThomson
added a commit
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small change in support of #70272 and a future PR involving editing visualizations by value. This adds a standard method for adding or replacing a panel on a dashboard.
The update portion of this method will be simplified further by calling
panel.updateInput()once #70381 is fixed.Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser- [ ] This was checked for cross-browser compatibilityFor maintainers