Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Preserve compressed artifacts when updating manifest #71196

Merged
merged 4 commits into from
Jul 9, 2020
Merged

[Security Solution][Endpoint] Preserve compressed artifacts when updating manifest #71196

merged 4 commits into from
Jul 9, 2020

Conversation

madirey
Copy link
Contributor

@madirey madirey commented Jul 9, 2020 •
edited
Loading

Summary

Unchanged artifacts were being overwritten in the manifest every time there was an update. This resulted in unchanged artifacts having incorrect compression algorithm data.

This PR corrects that behavior.

image (7)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@madirey madirey added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team Feature:Endpoint Elastic Endpoint feature v7.9.0 labels Jul 9, 2020
@madirey madirey requested review from a team as code owners July 9, 2020 04:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-response (Team:Endpoint Response)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@madirey
Copy link
Contributor Author

madirey commented Jul 9, 2020

@elasticmachine merge upstream

@madirey
Copy link
Contributor Author

madirey commented Jul 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@madirey madirey merged commit 0d3f7a1 into elastic:master Jul 9, 2020
@madirey madirey deleted the fix-manifest-sync-bug branch July 9, 2020 18:00
@madirey madirey mentioned this pull request Jul 9, 2020
Merged
madirey added a commit that referenced this pull request Jul 9, 2020
@madirey @elasticmachine
Preserve compressed artifacts when updating manifest (#71196) (#71286)
95234bc 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexk307 alexk307 alexk307 approved these changes

@peluja1012 peluja1012 peluja1012 approved these changes

@crowens crowens Awaiting requested review from crowens

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madirey @elasticmachine @kibanamachine @peluja1012 @alexk307