migrate es version check to new client #71215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
14 tasks
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
reviewed
Jul 9, 2020
| internalClient.nodes.info.mockReturnValueOnce([ | ||
| { body: createNodes('5.1.0', '5.2.0', '5.0.0') }, | ||
| ]); | ||
| // @ts-expect-error we need to return an incompatible type to use the testScheduler here |
There was a problem hiding this comment.
Will this problem be solved when we switch to a client generated for Kibana?elastic/elasticsearch-js#1239
There was a problem hiding this comment.
Unfortunately no, this is the 'cannot use promises with marble scheduler' issue where we return an observable or a plain value instead of a promise to be used with rx.of. We just did not have the TS error with the legacy client because the mock was not correctly typed.
mshustov
approved these changes
Jul 9, 2020
…client-version-checl
…client-version-checl
💚 Build SucceededBuild metricsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jul 15, 2020
pgayvallet
added a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #35508
Migrate the ES version check to use the new ES client instead of the legacy one.
Note: this is targeting
7.10and should not be merged / backported to7.9Checklist