[ILM] Fix alignment of the timing field #71273

yuliacech · 2020-07-09T16:42:27Z

Summary

This PR fixes the alignment of the Timing field for Warm, Cold and Delete phases on the Index Lifecycle Policy edit page. The "unit of time" label combobox is now shorter and more of the label is cut off, but I think cleaner alignment makes up for it. The longest label was cut in before as well.

Before

Warm phase

Cold phase

Delete phase

After

Warm phase

Cold phase

Delete phase

Release note

We fixed the alignment of the Timing field for Warm, Cold and Delete phases on the Index Lifecycle Policy edit page.

elasticmachine · 2020-07-09T16:44:21Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal · 2020-07-09T21:42:11Z

Can we make the width of the first input (time value) narrower in order to make the width of the second input (time unit) wider? That might prevent the text from being cut off (when it's in English at least).

alisonelizabeth · 2020-07-13T19:46:08Z

@elasticmachine merge upstream

alisonelizabeth · 2020-07-13T20:18:25Z

Can we make the width of the first input (time value) narrower in order to make the width of the second input (time unit) wider? That might prevent the text from being cut off (when it's in English at least).

@cjcenizal good suggestion! I played around with this. Would you also expect the other number input fields to align with this new width? For example:

Also, I noticed the other time/value inputs used in the form are using 188px as the width (aligning with Yulia's change), so we would need to update these as well if we go with your suggestion.

cjcenizal · 2020-07-13T20:28:08Z

@alisonelizabeth I don’t think we need to make all of the number inputs the same width. That feels like knolling to me — kinda neat and aesthetically pleasing, but perhaps not universally useful. I’d rather uncouple them from one another and use whichever width works best in each case. And if they end up being the same width, then that’d be a nice bonus in my opinion. :)

alisonelizabeth · 2020-07-13T21:10:51Z

@cjcenizal good point!

I updated the PR. Would you mind taking another look?

Here's a screenshot of the full form, with the changed inputs highlighted in red.

cjcenizal

LGTM when testing locally! While we're here can we also make the snapshot repositories callout regular size instead of small? You can see the discrepancy compared to the node attributes callout.

alisonelizabeth · 2020-07-13T22:19:50Z

@cjcenizal good catch! Fixed.

kibanamachine · 2020-07-14T00:13:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b0207b7

Build metrics

‼️ unable to find a baseline build for [master@7282597]. Try merging the upstream branch and trying again.

History

💚 Build #61102 succeeded 91b8c52
💚 Build #61068 succeeded 97c1e31
💚 Build #60326 succeeded f9953c1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (314 commits) [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540) initial telemetry setup (elastic#69330) [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027) Search across spaces (elastic#67644) ...

…t-apps-page-titles * 'master' of github.com:elastic/kibana: (88 commits) [ML] Functional tests - disable DFA creation and cloning tests [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540) initial telemetry setup (elastic#69330) [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027) ... # Conflicts: # x-pack/plugins/index_management/public/application/index.tsx

* master: (72 commits) [test] Skips test preventing promotion of ES snapshot elastic#71612 [Logs UI] Remove UUID from Alert Instances (elastic#71340) [Metrics UI] Remove UUID from Alert Instance IDs (elastic#71335) [ML] Functional tests - disable DFA creation and cloning tests [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) ...

[ILM] Fix alignment of the timing field

f9953c1

yuliacech requested a review from a team as a code owner July 9, 2020 16:42

yuliacech added Feature:ILM release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.0 v8.0.0 labels Jul 9, 2020

Merge branch 'master' into master

97c1e31

address feedback

91b8c52

alisonelizabeth requested a review from cjcenizal July 13, 2020 21:08

cjcenizal approved these changes Jul 13, 2020

View reviewed changes

fix no snapshots callout

b0207b7

alisonelizabeth merged commit 56a2437 into elastic:master Jul 14, 2020

alisonelizabeth mentioned this pull request Jul 14, 2020

[7.x] [ILM] Fix alignment of the timing field (#71273) #71581

Merged

alisonelizabeth pushed a commit to alisonelizabeth/kibana that referenced this pull request Jul 14, 2020

[ILM] Fix alignment of the timing field (elastic#71273)

2058471

alisonelizabeth added a commit that referenced this pull request Jul 14, 2020

[ILM] Fix alignment of the timing field (#71273) (#71581)

1ea8500

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ILM] Fix alignment of the timing field #71273

[ILM] Fix alignment of the timing field #71273

yuliacech commented Jul 9, 2020 •

edited

Loading

elasticmachine commented Jul 9, 2020

cjcenizal commented Jul 9, 2020

alisonelizabeth commented Jul 13, 2020

alisonelizabeth commented Jul 13, 2020

cjcenizal commented Jul 13, 2020

alisonelizabeth commented Jul 13, 2020

cjcenizal left a comment

alisonelizabeth commented Jul 13, 2020

kibanamachine commented Jul 14, 2020

[ILM] Fix alignment of the timing field #71273

[ILM] Fix alignment of the timing field #71273

Conversation

yuliacech commented Jul 9, 2020 • edited Loading

Summary

Before

Warm phase

Cold phase

Delete phase

After

Warm phase

Cold phase

Delete phase

Release note

elasticmachine commented Jul 9, 2020

cjcenizal commented Jul 9, 2020

alisonelizabeth commented Jul 13, 2020

alisonelizabeth commented Jul 13, 2020

cjcenizal commented Jul 13, 2020

alisonelizabeth commented Jul 13, 2020

cjcenizal left a comment

Choose a reason for hiding this comment

alisonelizabeth commented Jul 13, 2020

kibanamachine commented Jul 14, 2020

💚 Build Succeeded

Build metrics

History

yuliacech commented Jul 9, 2020 •

edited

Loading