-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Log a warning if registryUrl is set in non gold #71514
Merged
nchaulet
merged 3 commits into
elastic:master
from
nchaulet:feature-warning-custom-url-non-gold
Jul 13, 2020
Merged
[Ingest Manager] Log a warning if registryUrl is set in non gold #71514
nchaulet
merged 3 commits into
elastic:master
from
nchaulet:feature-warning-custom-url-non-gold
Jul 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
Team:Fleet
Team label for Observability Data Collection Fleet team
Ingest Management:beta1
labels
Jul 13, 2020
Pinging @elastic/ingest-management (Team:Ingest Management) |
@elasticmachine merge upstream |
jen-huang
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left copy suggestion. Thanks for adding this!
x-pack/plugins/ingest_manager/server/services/epm/registry/registry_url.ts
Outdated
Show resolved
Hide resolved
…istry_url.ts Co-authored-by: Jen Huang <its.jenetic@gmail.com>
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/saved_objects_management/edit_saved_object·ts.saved objects management saved objects edition page allows to delete a saved objectStandard Out
Stack Trace
Build metrics
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jul 13, 2020
nchaulet
added a commit
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently user need to have a gold licence to set a custom EPM registry url, otherwise it will silently use the default one.
This PR add a warning in the log message if customUrl is set and no gold licence are active.
How to test?
Run ES with a basic licence, and set the customUrl you should see a warning message.