[SecuritySolution][Resolver] Adding siem index and guarding process ancestry #71570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
v8.0.0
release_note:skip
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
michaelolo24
approved these changes
Jul 14, 2020
james-elastic
approved these changes
Jul 14, 2020
oatkiller
reviewed
Jul 14, 2020
| /* | ||
| * The array has a special format. The entity_ids towards the beginning of the array are closer ancestors and the | ||
| * values towards the end of the array are more distant ancestors (grandparents). Therefore | ||
| * ancestry_array[0] == process.parent.entity_id and ancestry_array[1] == process.parent.parent.entity_id | ||
| */ | ||
| ancestry: string[]; | ||
| ancestry?: string[]; |
There was a problem hiding this comment.
my understanding is that all fields and subfields are optional (and untyped) in ecs. maybe runtime validation would be a better solution for this issue.
oatkiller
reviewed
Jul 14, 2020
| @@ -18,6 +18,11 @@ export function handleEntities(): RequestHandler<unknown, TypeOf<typeof validate | |||
| query: { _id, indices }, | |||
| } = request; | |||
|
|
|||
| const siemClient = context.securitySolution!.getAppClient(); | |||
| const queryIndices = indices; | |||
There was a problem hiding this comment.
why is this reassignment being done?
oatkiller
reviewed
Jul 14, 2020
| const siemClient = context.securitySolution!.getAppClient(); | ||
| const queryIndices = indices; | ||
| // if the alert was promoted by a rule it will exist in the signals index so search there too | ||
| queryIndices.push(siemClient.getSignalsIndex()); |
There was a problem hiding this comment.
if this route is going to be siem specific, maybe we can rename it?
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Jul 14, 2020
…ncestry (elastic#71570) * Adding siem index and guarding process ancestry * Fixing type errors
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 14, 2020
* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
.siem-signalsindex to the list of ones queried to find the event that is clicked on in timelineprocess.Ext.ancestryas to force users of it to check for undefined. There's been a couple cases where the endpoint hasn't sent it which causes a crash in kibanaI tested the siem index retrieval using both generated data and an actual endpoint. I verified that the
/entityrequest returns the correctentity_idfor both cases.Working signal resolver using generated data