[APM] Aggregated transaction telemetry #71594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
smith
force-pushed
the
nls/trans-agg-telem
branch
from
13ad824
to
ef84a6f
Compare
dgieselaar
reviewed
Jul 14, 2020
Comment on lines
151
to
211
| return { | ||
| aggregated_transactions: { | ||
| current_implementation: { | ||
| transaction_count: allCount, | ||
| expected_metric_document_count: | ||
| allResult.aggregations?.current_implementation.buckets.length, | ||
| }, | ||
| no_observer_name: { | ||
| transaction_count: allCount, | ||
| expected_metric_document_count: | ||
| allResult.aggregations?.no_observer_name.buckets.length, | ||
| }, | ||
| no_rum: { | ||
| transaction_count: noRumCount, | ||
| expected_metric_document_count: | ||
| noRumResult.aggregations?.no_rum.buckets.length, | ||
| }, | ||
| no_rum_no_observer_name: { | ||
| transaction_count: noRumCount, | ||
| expected_metric_document_count: | ||
| noRumResult.aggregations?.no_rum_no_observer_name.buckets.length, | ||
| }, | ||
| only_rum: { | ||
| transaction_count: rumCount, | ||
| expected_metric_document_count: | ||
| rumResult.aggregations?.only_rum.buckets.length, | ||
| }, | ||
| only_rum_no_observer_name: { | ||
| transaction_count: rumCount, | ||
| expected_metric_document_count: | ||
| rumResult.aggregations?.only_rum_no_observer_name.buckets.length, | ||
| }, | ||
| }, | ||
| }; | ||
| }, | ||
| }, |
There was a problem hiding this comment.
FWICT the results of the buckets are not being paginated through, so they will always return <= 10k. It might be a (lot) more than that (I've seen 60k+). The script I mentioned also paginates through the buckets (by using after_key).
dgieselaar
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
I don't see any other issues but I'm on my phone so no guarantees 😬 approving with the assumption the pagination is added. & Thank you again @smith !
Add a task to gather transasctions telemetry as described in elastic#71593. Also: * Fix typo in mapping for country code mapping * Add back `mergeTelemetryMapping` function to fix broken `upload-telemetry-data` script.
smith
force-pushed
the
nls/trans-agg-telem
branch
from
056e090
to
4b0523b
Compare
smith
added
v7.9.0
release_note:skip
|
@elastic/telemetry this PR contains updates to our mapping. See the snapshot diff for details: https://github.com/elastic/kibana/pull/71594/files#diff-229bb3e007b2caea8d59390783ccb586 |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Jul 16, 2020
Add a task to gather transasctions telemetry as described in elastic#71593. Also: * Fix typo in mapping for country code mapping * Add back `mergeTelemetryMapping` function to fix broken `upload-telemetry-data` script.
smith
added a commit
to smith/kibana
that referenced
this pull request
Jul 16, 2020
Add a task to gather transasctions telemetry as described in elastic#71593. Also: * Fix typo in mapping for country code mapping * Add back `mergeTelemetryMapping` function to fix broken `upload-telemetry-data` script.
smith
added a commit
that referenced
this pull request
Jul 16, 2020
Add a task to gather transasctions telemetry as described in #71593. Also: * Fix typo in mapping for country code mapping * Add back `mergeTelemetryMapping` function to fix broken `upload-telemetry-data` script. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
smith
added a commit
that referenced
this pull request
Jul 17, 2020
Add a task to gather transasctions telemetry as described in #71593. Also: * Fix typo in mapping for country code mapping * Add back `mergeTelemetryMapping` function to fix broken `upload-telemetry-data` script. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a task to gather transasctions telemetry as described in #71593.
Also:
mergeTelemetryMappingfunction to fix brokenupload-telemetry-datascript.Fixes #71593