[Index Management] Adopt data stream API changes #71682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
release_note:fix
Feature:Index Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@tylersmalley that code is part of Snapshot and Restore. I believe @jloleysens said no changes are needed there, but going to look into again and verify. |
|
@tylersmalley Update - I believe the Snapshot + Restore code you pointed to is still valid and no changes are needed. The ES change only relates to when defining a data stream while creating a composable index template. |
cjcenizal
approved these changes
Jul 14, 2020
| return { | ||
| timestamp_field: '@timestamp', | ||
| }; | ||
| // For now, ES expects an empty empty when defining a data stream |
There was a problem hiding this comment.
Typo: "empty empty" -> "empty object"
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Jul 14, 2020
tylersmalley
pushed a commit
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-part towards #71670
This PR updates the data streams API integration test and fixes the composable templates creation flow.
How to test
Verify the composable index template creation flow works as expected when enabling the data streams toggle.