Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes timestamp_field from data_stream #71727

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Jul 14, 2020

Multi-part towards #71670

This option was removed in elastic/elasticsearch#59317 and is currently blocking the promotion of our nightly Elasticsearch build.

elastic#71670

Caused by elastic/elasticsearch#59317

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added blocker v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 14, 2020
@tylersmalley tylersmalley requested a review from a team July 14, 2020 18:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@neptunian
Copy link
Contributor

LGTM after jest snapshot test and type is updated

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 14, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 14, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

Temporarily skipped tests as ES requires this field prior to the breaking change:

main/8.0: e4546b3
7.x/7.9: acc92f4

tylersmalley pushed a commit that referenced this pull request Jul 14, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 14, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
Most fleet tests are colliding with the change to timestamp_field ES
change

#71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
Most fleet tests are colliding with the change to timestamp_field ES
change

#71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
Will be re-enabled in #71727

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley requested review from a team as code owners July 15, 2020 13:46
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

miscellaneous assets size

id value diff baseline
upgradeAssistant 22.6KB +9.0B 22.5KB

Saved Objects .kibana field count

id value diff baseline
_data_stream_timestamp 1 +1 -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mistic
Copy link
Member

mistic commented Jul 15, 2020

@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 6068285 into elastic:master Jul 15, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jul 15, 2020
elastic#71670

Caused by elastic/elasticsearch#59317

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jul 15, 2020
elastic#71670

Caused by elastic/elasticsearch#59317

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
#71670

Caused by elastic/elasticsearch#59317

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
#71670

Caused by elastic/elasticsearch#59317

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants