-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Bring Cypress tests back to life #71871
[SIEM] Bring Cypress tests back to life #71871
Conversation
Pinging @elastic/siem (Team:SIEM) |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_empty_screen·js.dashboard mode empty dashboard "before all" hook for "adds Lens visualization to empty dashboard"Standard Out
Stack Trace
Build metrics
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested manually with loop_cypress_tests.js 5
* fixes and unskips 'Detection rules, custom' * fixes 'Export rules' test * unksips 'Deleting prebuilt rules' test * unskips Alerts timeline * unskips 'Events viewer' tests * unskips 'toggle column in timeline' tests * unskips 'url timeline' test * fixes Overview test * skips flaky test # Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_export.spec.ts # x-pack/plugins/security_solution/cypress/objects/rule.ts # x-pack/test/security_solution_cypress/es_archives/custom_rule_with_timeline/data.json.gz # x-pack/test/security_solution_cypress/es_archives/custom_rule_with_timeline/mappings.json
* fixes and unskips 'Detection rules, custom' * fixes 'Export rules' test * unksips 'Deleting prebuilt rules' test * unskips Alerts timeline * unskips 'Events viewer' tests * unskips 'toggle column in timeline' tests * unskips 'url timeline' test * fixes Overview test * skips flaky test # Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_export.spec.ts # x-pack/plugins/security_solution/cypress/objects/rule.ts # x-pack/test/security_solution_cypress/es_archives/custom_rule_with_timeline/data.json.gz # x-pack/test/security_solution_cypress/es_archives/custom_rule_with_timeline/mappings.json
* fixes and unskips 'Detection rules, custom' * fixes 'Export rules' test * unksips 'Deleting prebuilt rules' test * unskips Alerts timeline * unskips 'Events viewer' tests * unskips 'toggle column in timeline' tests * unskips 'url timeline' test * fixes Overview test * skips flaky test # Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_export.spec.ts # x-pack/plugins/security_solution/cypress/objects/rule.ts # x-pack/test/security_solution_cypress/es_archives/custom_rule_with_timeline/data.json.gz # x-pack/test/security_solution_cypress/es_archives/custom_rule_with_timeline/mappings.json
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
In this PR we are fixing the failing tests and unskips the ones that are working fine.
Pending to fix:
because these tests needs an investment of time to understand what is happening an fix them.