[ML] Debounce annotation validation #71884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
| @@ -177,6 +177,8 @@ class AnnotationFlyoutUI extends Component<CommonProps & Props> { | |||
| return errors; | |||
| }; | |||
|
|
|||
| public debouncedValidateAnnotationText = debounce(this.validateAnnotationText, 300); | |||
There was a problem hiding this comment.
unless this is called by something externally, it should probably be private
|
After discussing with Pete, we both think the change doesn't make that dramatic of a difference so I'm gonna shelve this PR for now until we fix the performance issues with the AE/annotation flyout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR debounces the input when editing annotation text so the validation isn't run every single time the user types. This is part of the #69538. There will be a follow up PR to address more of the performance problems, especially in the Anomaly Explorer tab.
Checklist
Delete any items that are not applicable to this PR.