Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Cleanup (#71849) #71955

Merged
merged 1 commit into from
Jul 16, 2020
Merged

[7.x] Cleanup (#71849) #71955

merged 1 commit into from
Jul 16, 2020

Conversation

streamich
Copy link
Contributor

Backports the following commits to 7.x:

* chore: 🤖 update codeowners file

* refactor: 💡 rename whitelist -> allow-list in data plugin

* Update .github/CODEOWNERS

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/policy_list·ts.endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/71951

[00:00:00]       │
[00:00:00]         └-: endpoint
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] [metrics-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] [logs-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] [events-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:00:01]             │ proc [kibana]  error  [22:04:31.546] [warning][process] UnhandledPromiseRejectionWarning: Error: [epm-packages:endpoint]: version conflict, required seqNo [12], primary term [1]. current document has seqNo [13] and primary term [1]: [version_conflict_engine_exception] [epm-packages:endpoint]: version conflict, required seqNo [12], primary term [1]. current document has seqNo [13] and primary term [1], with { index_uuid="55HuDkm_QZOUGqxOfqh-wg" & shard="0" & index=".kibana_1" }
[00:00:01]             │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:00:01]             │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:00:01]             │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:00:01]             │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-8/node_modules/lodash/lodash.js:4929:19)
[00:00:01]             │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:00:01]             │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:00:01]             │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:00:01]             │ proc [kibana]     at emitWarning (internal/process/promises.js:97:15)
[00:00:01]             │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:00:01]             │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:00:01]             │ proc [kibana]  error  [22:04:31.548] [warning][process] Error: [epm-packages:endpoint]: version conflict, required seqNo [12], primary term [1]. current document has seqNo [13] and primary term [1]: [version_conflict_engine_exception] [epm-packages:endpoint]: version conflict, required seqNo [12], primary term [1]. current document has seqNo [13] and primary term [1], with { index_uuid="55HuDkm_QZOUGqxOfqh-wg" & shard="0" & index=".kibana_1" }
[00:00:01]             │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:00:01]             │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:00:01]             │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:00:01]             │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-8/node_modules/lodash/lodash.js:4929:19)
[00:00:01]             │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:00:01]             │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:00:01]             │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] added role [fleet_enroll]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] added user [fleet_enroll]
[00:00:01]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] [.kibana_1/55HuDkm_QZOUGqxOfqh-wg] update_mapping [_doc]
[00:00:02]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] [.kibana_1/55HuDkm_QZOUGqxOfqh-wg] update_mapping [_doc]
[00:00:02]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] [.kibana_1/55HuDkm_QZOUGqxOfqh-wg] update_mapping [_doc]
[00:00:02]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] [.kibana_1/55HuDkm_QZOUGqxOfqh-wg] update_mapping [_doc]
[00:00:04]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594846037115491654] adding index template [metrics-system.core] for index patterns [metrics-system.core-*]
[00:00:21]           └-: When on the Endpoint Policy List
[00:00:21]             └-> "before all" hook
[00:00:21]             └-> "before all" hook
[00:00:21]               │ debg navigateToActualUrl http://localhost:6181/app/security/administration/policy
[00:00:21]               │ debg browser[INFO] http://localhost:6181/app/security/administration/policy?_t=1594850691606 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:21]               │
[00:00:21]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:21]               │ debg currentUrl = http://localhost:6181/app/security/administration/policy
[00:00:21]               │          appUrl = http://localhost:6181/app/security/administration/policy
[00:00:21]               │ debg TestSubjects.find(kibanaChrome)
[00:00:21]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:22]               │ debg isGlobalLoadingIndicatorVisible
[00:00:22]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:22]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:22]               │ debg browser[INFO] http://localhost:6181/33333/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-15T22:04:52Z
[00:00:22]               │        Adding connection to http://localhost:6181/elasticsearch
[00:00:22]               │
[00:00:22]               │      "
[00:00:23]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:23]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:23]               │ERROR browser[SEVERE] http://localhost:6181/api/detection_engine/index - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:00:23]             └-> loads the Policy List Page
[00:00:23]               └-> "before each" hook: global before each
[00:00:23]               │ debg TestSubjects.exists(policyListPage)
[00:00:23]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="policyListPage"]') with timeout=120000
[00:00:23]               └- ✓ pass  (27ms) "endpoint When on the Endpoint Policy List loads the Policy List Page"
[00:00:23]             └-> displays page title
[00:00:23]               └-> "before each" hook: global before each
[00:00:23]               │ debg TestSubjects.getVisibleText(pageViewHeaderLeftTitle)
[00:00:23]               │ debg TestSubjects.find(pageViewHeaderLeftTitle)
[00:00:23]               │ debg Find.findByCssSelector('[data-test-subj="pageViewHeaderLeftTitle"]') with timeout=10000
[00:00:23]               └- ✓ pass  (24ms) "endpoint When on the Endpoint Policy List displays page title"
[00:00:23]             └-> shows header create policy button
[00:00:23]               └-> "before each" hook: global before each
[00:00:23]               │ debg TestSubjects.getVisibleText(headerCreateNewPolicyButton)
[00:00:23]               │ debg TestSubjects.find(headerCreateNewPolicyButton)
[00:00:23]               │ debg Find.findByCssSelector('[data-test-subj="headerCreateNewPolicyButton"]') with timeout=10000
[00:00:23]               └- ✓ pass  (30ms) "endpoint When on the Endpoint Policy List shows header create policy button"
[00:00:23]             └-> shows empty state
[00:00:23]               └-> "before each" hook: global before each
[00:00:23]               │ debg TestSubjects.exists(emptyPolicyTable)
[00:00:23]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="emptyPolicyTable"]') with timeout=120000
[00:00:23]               └- ✓ pass  (23ms) "endpoint When on the Endpoint Policy List shows empty state"
[00:00:23]             └-: and policies exists
[00:00:23]               └-> "before all" hook
[00:00:23]               └-> "before all" hook
[00:00:25]                 │ info Setting up call to retrieve Endpoint package from /api/ingest_manager/epm/packages?category=security
[00:00:29]                 │ proc [kibana]   log   [22:04:59.755] [info][plugins][plugins][securitySolution][securitySolution] Committed manifest WzAsMF0=
[00:00:31]                 │ debg navigateToActualUrl http://localhost:6181/app/security/administration/policy
[00:00:31]                 │ debg browser[INFO] http://localhost:6181/app/security/administration/policy?_t=1594850701821 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:31]                 │
[00:00:31]                 │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:31]                 │ debg currentUrl = http://localhost:6181/app/security/administration/policy
[00:00:31]                 │          appUrl = http://localhost:6181/app/security/administration/policy
[00:00:31]                 │ debg TestSubjects.find(kibanaChrome)
[00:00:31]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:33]                 │ debg isGlobalLoadingIndicatorVisible
[00:00:33]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:33]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:33]                 │ debg browser[INFO] http://localhost:6181/33333/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-15T22:05:03Z
[00:00:33]                 │        Adding connection to http://localhost:6181/elasticsearch
[00:00:33]                 │
[00:00:33]                 │      "
[00:00:33]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:33]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:34]                 │ERROR browser[SEVERE] http://localhost:6181/api/detection_engine/index - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:00:34]                 │ debg Waiting up to 2000ms for table to have data...
[00:00:34]                 │ debg TestSubjects.exists(policyTable)
[00:00:34]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="policyTable"]') with timeout=2500
[00:00:34]                 │ debg TestSubjects.find(policyTable)
[00:00:34]                 │ debg Find.findByCssSelector('[data-test-subj="policyTable"]') with timeout=10000
[00:00:41]             └-: and user clicks on page header create button
[00:00:41]               └-> "before all" hook
[00:00:41]               └-> should redirect to ingest management integrations add package config
[00:00:41]                 └-> "before each" hook: global before each
[00:00:41]                 └-> "before each" hook
[00:00:41]                   │ debg navigateToActualUrl http://localhost:6181/app/security/administration/policy
[00:00:41]                   │ debg browser[INFO] http://localhost:6181/app/security/administration/policy?_t=1594850712046 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:41]                   │
[00:00:41]                   │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:41]                   │ debg currentUrl = http://localhost:6181/app/security/administration/policy
[00:00:41]                   │          appUrl = http://localhost:6181/app/security/administration/policy
[00:00:41]                   │ debg TestSubjects.find(kibanaChrome)
[00:00:41]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:43]                   │ debg isGlobalLoadingIndicatorVisible
[00:00:43]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:43]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:43]                   │ debg browser[INFO] http://localhost:6181/33333/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-15T22:05:13Z
[00:00:43]                   │        Adding connection to http://localhost:6181/elasticsearch
[00:00:43]                   │
[00:00:43]                   │      "
[00:00:43]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:43]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:43]                   │ERROR browser[SEVERE] http://localhost:6181/api/detection_engine/index - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:00:43]                   │ debg TestSubjects.find(headerCreateNewPolicyButton)
[00:00:43]                   │ debg Find.findByCssSelector('[data-test-subj="headerCreateNewPolicyButton"]') with timeout=10000
[00:00:43]                   │ debg TestSubjects.find(headerCreateNewPolicyButton)
[00:00:43]                   │ debg Find.findByCssSelector('[data-test-subj="headerCreateNewPolicyButton"]') with timeout=10000
[00:00:44]                 │ debg TestSubjects.exists(createPackageConfig_header)
[00:00:44]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createPackageConfig_header"]') with timeout=120000
[00:00:44]                 │ proc [kibana]   log   [22:05:14.699] [error][ingestManager][plugins] [epm-packages:endpoint]: version conflict, required seqNo [12], primary term [1]. current document has seqNo [13] and primary term [1]: [version_conflict_engine_exception] [epm-packages:endpoint]: version conflict, required seqNo [12], primary term [1]. current document has seqNo [13] and primary term [1], with { index_uuid="55HuDkm_QZOUGqxOfqh-wg" & shard="0" & index=".kibana_1" }
[00:00:44]                 │ proc [kibana]  error  [22:05:14.718] [warning][process] PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
[00:00:44]                 │ proc [kibana]     at handledRejection (internal/process/promises.js:71:23)
[00:00:44]                 │ proc [kibana]     at promiseRejectHandler (internal/process/promises.js:36:14)
[00:00:44]                 │ proc [kibana]     at Promise.then (<anonymous>)
[00:00:44]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
[00:00:46]                 │ERROR browser[SEVERE] http://localhost:6181/api/ingest_manager/setup - Failed to load resource: the server responded with a status of 409 (Conflict)
[00:00:46]                 │ debg --- retry.tryForTime error: [data-test-subj="createPackageConfig_header"] is not displayed
[00:00:49]                 │ debg --- retry.tryForTime failed again with the same message...
[00:00:52]                 │ debg --- retry.tryForTime failed again with the same message...
[00:00:55]                 │ debg --- retry.tryForTime failed again with the same message...
[00:00:58]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:01]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:04]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:07]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:10]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:13]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:16]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:20]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:23]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:26]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:29]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:32]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:35]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:38]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:41]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:44]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:47]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:50]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:53]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:56]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:59]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:02]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:05]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:08]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:11]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:14]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:17]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:20]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:23]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:27]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:30]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:33]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:36]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:39]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:42]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:45]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:45]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config.png"
[00:02:46]                 │ info Current URL is: http://localhost:6181/app/ingestManager#/integrations/endpoint-0.10.0/add-integration
[00:02:46]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config.html
[00:02:46]                 └- ✖ fail: endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config
[00:02:46]                 │      Error: expected testSubject(createPackageConfig_header) to exist
[00:02:46]                 │       at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/common/test_subjects.ts:62:15)
[00:02:46]                 │ 
[00:02:46]                 │ 

Stack Trace

Error: expected testSubject(createPackageConfig_header) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/common/test_subjects.ts:62:15)

Build metrics

page load bundle size

id value diff baseline
data 1.5MB -12.0B 1.5MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit ba982ff into elastic:7.x Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants