Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate status page app to core #72017
Migrate status page app to core #72017
Changes from 2 commits
ba9e213
5964ffc
f63d8d2
dcc1f0a
6b42c45
854211e
c4dbd19
7f927f7
c857b74
8a2f98e
0a7b243
d65c125
7bdc3c2
e91d5b7
b7bc230
4beb5d3
66337af
46c5adf
716dee7
92924b7
7352ad9
3a3e2e9
5b8719e
1a0c2ae
920f52b
71f4273
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add tests for an anonymous user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to add an x-pack suite for that, as the current suite is running on OSS. Should I do so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add it. Config is a public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nm, there is already one:
kibana/x-pack/test/functional/apps/status_page/status_page.ts
Lines 20 to 24 in 0f9efa8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add a similar test when
status.allowAnonymous
isfalse
, but that would require to create a specific test suite to start the server with the correct option. Either that, or I can just add a unit test forsrc/core/server/core_app/core_app.ts
to ensure the route is declared with correct options depending on the configuration value. wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍