Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Disable asset facet links #72158

Merged
merged 4 commits into from
Jul 20, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Fixes #70441. As our current asset facet buttons don't do anything when clicked, this PR disables them and adds styling to make them look not-disabled. This is largely a temporary fix until this area is revamped.

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.10.0 v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 16, 2020
@jen-huang jen-huang requested a review from a team July 16, 2020 20:40
@jen-huang jen-huang self-assigned this Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang added the release_note:skip Skip the PR/issue when compiling release notes label Jul 16, 2020
@jen-huang
Copy link
Contributor Author

@elasticmachine merge upstream

@jen-huang
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestManager 1.1MB +249.0B 1.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit 0f964f6 into elastic:master Jul 20, 2020
@jen-huang jen-huang deleted the ingest/fix/asset-links branch July 20, 2020 19:14
jen-huang added a commit to jen-huang/kibana that referenced this pull request Jul 20, 2020
* Disable asset facets

* Fix prop name

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang added a commit that referenced this pull request Jul 20, 2020
* Disable asset facets

* Fix prop name

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang added a commit that referenced this pull request Jul 20, 2020
* Disable asset facets

* Fix prop name

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v7.10.0 v8.0.0
Projects
None yet
4 participants