[ML] Fix annotations pagination & change labels from letters to numbers #72204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
| return ( | ||
| <Fragment> | ||
| <EuiInMemoryTable | ||
| error={searchError} | ||
| className="eui-textOverflowWrap" | ||
| compressed={true} | ||
| items={this.getAnnotationsWithExtraInfo(annotations)} | ||
| items={items} | ||
| columns={columns} |
There was a problem hiding this comment.
The Label column should sort numerically:
I think you can just replace sortable: true with something like sortable: (key) => +key,
There was a problem hiding this comment.
Updated the sort for numerical labels here 5e43657
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
This was referenced Jul 17, 2020
Merged
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Jul 17, 2020
qn895
added a commit
that referenced
this pull request
Jul 18, 2020
qn895
added a commit
that referenced
this pull request
Jul 18, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 20, 2020
* master: [Observability] Remove app logos (elastic#72259) Fix float percentiles line chart (elastic#71902) update chromedriver to 84 (elastic#72228) [esArchiver] actually re-delete the .kibana index if we lose recreate race (elastic#72354) [Maps] convert SavedGisMap to TS (elastic#72286) [DOCS] Removes occurrences of X-Pack Security and Reporting (elastic#72302) use WORKSPACE env var for stack_functional_integration tests, fix navigate path (elastic#71908) [Monitoring] Fix issue with ES node detail status (elastic#72298) [SIEM] Updates consumer in export_rule archive (elastic#72324) [kbn/dev-utils] add RunWithCommands utility (elastic#72311) [Security Solution][Endpoint][Exceptions] Only write manifest to policy when there are changes (elastic#72000) skip flaky suite (elastic#72339) [ML] Fix annotations pagination & change labels from letters to numbers (elastic#72204) [Lens] Fix switching with layers (elastic#71982) [Maps] 7.9 documenation updates (elastic#71893) docs: ✏️ add "Explore underlying data" user docs (elastic#70807) [Security Solution][Exceptions] - Remove initial add exception item button in builder (elastic#72215) Fix indentation level in code exploration doc (elastic#72274) register graph usage (elastic#72041) [Monitoring] Added a case for Alerting if security/ssl is disabled (elastic#71846)
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with pagination in the AnnotationsTable which only happens if you click on the last page in SMV.
Before (click on the last page of the table will trigger annotation on the chart and go back to page 1):
Fixed:
It also updates the labels from characters to numbers (starting at 1).
Before:
After:
