Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Testing error rate API and restructuring folders #72257

Merged
merged 8 commits into from
Jul 20, 2020
Merged

[APM] Testing error rate API and restructuring folders #72257

merged 8 commits into from
Jul 20, 2020

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jul 17, 2020 •
edited
Loading

Screenshot 2020-07-17 at 13 30 48

Screenshot 2020-07-17 at 13 25 29

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 17, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 17, 2020 11:27
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes removed the request for review from sorenlouv July 17, 2020 11:58
sorenlouv
sorenlouv reviewed Jul 20, 2020
View reviewed changes
x-pack/test/apm_api_integration/trial/tests/transaction_groups/error_rate.ts Outdated
});
});
});
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I wrote this comment already but I can't find it so might have forgotten to submit: I don't think we should have duplicate basic and trial tests if they are exactly the same. As a rule of thumb we should test everything in basic, and only add trial tests if behaviour changes with the license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could annotate tests with a license, thereby making it possible to run the same test for both licenses without duplicating it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have duplicate basic and trial tests if they are exactly the same

Thanks for clarifying it, I thought it was useless duplicating the test too. Just removed it.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 7976e2b into elastic:master Jul 20, 2020
@cauemarcondes cauemarcondes deleted the apm-error-rate-api-test branch July 20, 2020 10:39
sorenlouv pushed a commit to sorenlouv/kibana that referenced this pull request Jul 20, 2020
@cauemarcondes
[APM] Testing error rate API and restructuring folders (elastic#72257)
6c8cbc4 
* adding error rate and restructuring tests

* removing console log

* removing console log

* adding error rate and restructuring tests

* fixing TS error

* removing unnecessary files

* removing trial tests
@sorenlouv sorenlouv mentioned this pull request Jul 20, 2020
Merged
@sorenlouv
Copy link
Member

💚 Backport successful

The PR was backported to the following branches:

@cauemarcondes cauemarcondes mentioned this pull request Jul 20, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jul 20, 2020
@cauemarcondes
[APM] Testing error rate API and restructuring folders (elastic#72257)
1adbedf 
* adding error rate and restructuring tests

* removing console log

* removing console log

* adding error rate and restructuring tests

* fixing TS error

* removing unnecessary files

* removing trial tests
cauemarcondes added a commit that referenced this pull request Jul 20, 2020
@sorenlouv @cauemarcondes
[APM] Testing error rate API and restructuring folders (#72257) (#72410)
c80928a 
* adding error rate and restructuring tests

* removing console log

* removing console log

* adding error rate and restructuring tests

* fixing TS error

* removing unnecessary files

* removing trial tests

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Jul 20, 2020
@cauemarcondes
[APM] Testing error rate API and restructuring folders (#72257) (#72411)
7d5abed 
* adding error rate and restructuring tests

* removing console log

* removing console log

* adding error rate and restructuring tests

* fixing TS error

* removing unnecessary files

* removing trial tests
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 20, 2020
@gmmorris
Merge branch 'master' into task-manager/batch-update-delete
d9a1b62 
* master: (60 commits)
  [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335)
  [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337)
  [Resolver] no longer pass related event stats to process node component (elastic#72435)
  Revert "skip flaky suite (elastic#72146)"
  [Security Solution] Cleanup endpoint telemetry (elastic#71950)
  Unskip dashboard embeddable rendering tests (elastic#71824)
  [ENDPOINT] Added unerolling status for host. (elastic#72303)
  [Alerting][Connectors] Increase the size of the logos (elastic#72419)
  [SECURITY] [Timeline] Raw events not displayed (elastic#72387)
  [ML] Fixes display of regression stop stats if one is NaN (elastic#72412)
  [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239)
  Fix match phrase and not match phrase comparators (elastic#71850)
  [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040)
  [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152)
  [Resolver] Selector performance (elastic#72380)
  [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026)
  [Ingest Manager] Do not bumb config revision during config creation (elastic#72270)
  [ML] Adding missing index pattern name to new job wizards (elastic#72400)
  [ML] improve annotation flyout performance (elastic#72299)
  [APM] Testing error rate API and restructuring folders (elastic#72257)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 20, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
7febd47 
* master: (26 commits)
  [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335)
  [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337)
  [Resolver] no longer pass related event stats to process node component (elastic#72435)
  Revert "skip flaky suite (elastic#72146)"
  [Security Solution] Cleanup endpoint telemetry (elastic#71950)
  Unskip dashboard embeddable rendering tests (elastic#71824)
  [ENDPOINT] Added unerolling status for host. (elastic#72303)
  [Alerting][Connectors] Increase the size of the logos (elastic#72419)
  [SECURITY] [Timeline] Raw events not displayed (elastic#72387)
  [ML] Fixes display of regression stop stats if one is NaN (elastic#72412)
  [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239)
  Fix match phrase and not match phrase comparators (elastic#71850)
  [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040)
  [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152)
  [Resolver] Selector performance (elastic#72380)
  [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026)
  [Ingest Manager] Do not bumb config revision during config creation (elastic#72270)
  [ML] Adding missing index pattern name to new job wizards (elastic#72400)
  [ML] improve annotation flyout performance (elastic#72299)
  [APM] Testing error rate API and restructuring folders (elastic#72257)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv