-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] [6.8] Pipeline backports #72293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
release_note:skip
Skip the PR/issue when compiling release notes
v6.8.11
labels
Jul 17, 2020
@elasticmachine merge upstream |
@elasticmachine merge upstream |
spalger
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request, but LGTM
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Feature:CI
Continuous integration
release_note:skip
Skip the PR/issue when compiling release notes
v6.8.11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69964
I checked out 6.8, copied over all of the Pipeline-related files from master, and then removed the tasks and such not relevant for 6.8. All of the pipeline files are really close to what they are in master now, which should make backporting easier.
The test results in Jenkins for the PR match the base branch, and GCS uploads look good.
This should bring a bunch of fixes, some big and some small, e.g. slack notifications not working at all for 6.8.
If you want to actually review the changes, my recommendation would be to diff
vars/
,Jenkinsfile
, and.ci/es-snapshots
against master. The changes are really minimal.Here's
vars/
: