Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Validate file type of value lists #72746

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[Security Solution][Detections] Validate file type of value lists #72746

merged 2 commits into from
Jul 21, 2020

Commits on Jul 21, 2020

  1. UI validates file type of uploaded value list 

    * file picker itself is restricted to text/csv and text/plain
* if they drag/drop an invalid file, we disable the upload button and
display an error message
* refactors form state to be a File instead of a FileList
    @rylnd
    rylnd committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    9aa4a54 View commit details
    Browse the repository at this point in the history

  2. Refactor validation and error message in terms of file type 

    Instead of maintaining lists of both valid extensions and valid mime
types, we simply use the latter.
    @rylnd
    rylnd committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    2a9caf3 View commit details
    Browse the repository at this point in the history