[Monitoring] Ensure monitoring bulk uploader and stats api are more closely aligned #73325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
mshustov
approved these changes
Jul 30, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Jul 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Jul 31, 2020
|
Backport: 7.x: 88d1b2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack monitoring team maintains a set of parity tests between legacy and metricbeat collection, and we recently noticed failures as a result of #70677 in relation to the
kibana_stats.usage.searchdata set. The metricbeat-collected document didn't contain thetotalfield whereas the legacy-collected document did. After digging a bit, thetotalfield does not actually come from the newly added collector, but rather it's from an older one: https://github.com/elastic/kibana/blob/master/src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.ts#L73.The parity test failure is a result of handling key merging differently: using defaultsDeep in legacy collection and using object spreading for metricbeat collection.
This PR ensures we use the same merging in both places