Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fix Custom Element functional test (and remove skip) #73727

Merged
merged 6 commits into from
Aug 4, 2020
Merged

[Canvas] Fix Custom Element functional test (and remove skip) #73727

merged 6 commits into from
Aug 4, 2020

Conversation

poffdeluxe
Copy link
Contributor

@poffdeluxe poffdeluxe commented Jul 29, 2020 •
edited
Loading

Fixes #63339

When I ran the flaky test runner, it seems like the failures were due to the modal window animation not completing before the next instruction was happening. In 42 runs, it failed 4 times: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/717/

After adding a short delay to allow the modal to open, in 92 runs, it failed 0 times:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/724/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/725/

@poffdeluxe poffdeluxe added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.10.0 v8.0.0 labels Aug 3, 2020
@poffdeluxe poffdeluxe changed the title Remove skip of custom elements [Canvas] Fix Custom Element functional test (and remove skip) Aug 3, 2020
@poffdeluxe poffdeluxe marked this pull request as ready for review August 3, 2020 16:17
@poffdeluxe poffdeluxe requested a review from a team as a code owner August 3, 2020 16:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611
crob611 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work figuring this out

@poffdeluxe poffdeluxe merged commit 7208a57 into elastic:master Aug 4, 2020
@poffdeluxe poffdeluxe deleted the canvas-fix-flaky-custom-elements branch August 4, 2020 14:18
@poffdeluxe poffdeluxe mentioned this pull request Aug 4, 2020
Merged
poffdeluxe added a commit that referenced this pull request Aug 4, 2020
@poffdeluxe
[Canvas] Fix Custom Element functional test (and remove skip) (#73727) (
4075200 
#74255)

* Remove skip of custom elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@poffdeluxe @elasticmachine @kibanamachine @crob611