Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] fixes linking errors to ML and Discover #73758

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Jul 29, 2020

Closes #73755 by removing the extra uri encoding from time ranges and using correct refreshValue rison types rather than just strings.

…ges and

using correct refreshValue rison types rather than just strings
@ogupte ogupte requested a review from a team as a code owner July 29, 2020 23:10
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 3.7MB +49.0B 3.7MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

import { useTimeSeriesExplorerHref } from './useTimeSeriesExplorerHref';

jest.mock('../../../../hooks/useApmPluginContext', () => ({
useApmPluginContext: () => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use MockApmPluginContextWrapper for tests like this.

@spalger spalger added v7.9.0 and removed 7.9.0 labels Jul 30, 2020
@ogupte ogupte merged commit 0d8846d into elastic:master Jul 30, 2020
kibanamachine pushed a commit that referenced this pull request Jul 30, 2020
* Closes #73755 by removing the extra uri encoding from time ranges and
using correct refreshValue rison types rather than just strings

* removes commented out test assertion
kibanamachine pushed a commit that referenced this pull request Jul 30, 2020
* Closes #73755 by removing the extra uri encoding from time ranges and
using correct refreshValue rison types rather than just strings

* removes commented out test assertion
@kibanamachine
Copy link
Contributor

💚 Backport successful

The PR was backported to the following branches:

ogupte added a commit that referenced this pull request Jul 30, 2020
* Closes #73755 by removing the extra uri encoding from time ranges and
using correct refreshValue rison types rather than just strings

* removes commented out test assertion

Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
ogupte added a commit that referenced this pull request Jul 30, 2020
* Closes #73755 by removing the extra uri encoding from time ranges and
using correct refreshValue rison types rather than just strings

* removes commented out test assertion

Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
* master: (54 commits)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
* master: (38 commits)
  [Discover] Context unskip date nanos functional tests (elastic#73781)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:APM All issues that need APM UI Team support v7.9.0 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Errors when linking from service map to ML
6 participants