Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] convert dynamic icon style to TS #73903

Merged
merged 6 commits into from
Aug 3, 2020
Merged

[Maps] convert dynamic icon style to TS #73903

merged 6 commits into from
Aug 3, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 30, 2020

No description provided.

@nreese nreese added chore WIP Work in progress [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 30, 2020
@nreese nreese requested a review from a team as a code owner July 30, 2020 23:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from nickpeihl July 31, 2020 13:26
@nreese nreese removed the WIP Work in progress label Jul 31, 2020
@nreese
Copy link
Contributor Author

nreese commented Jul 31, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Aug 3, 2020

@elasticmachine merge upstream

@nreese nreese requested review from thomasneirynck and removed request for nickpeihl August 3, 2020 16:42
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.3MB +582.0B 3.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

code review lgtm

@nreese nreese merged commit cd1b1b3 into elastic:master Aug 3, 2020
nreese added a commit to nreese/kibana that referenced this pull request Aug 3, 2020
@nreese @elasticmachine
[Maps] convert dynamic icon style to TS (elastic#73903)
d6e4675 
* [Maps] convert dynmaic icon style to TS

* tslint

* fix snapsshot name changes caused by file name changes

* revert change that is not part of PR

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Aug 3, 2020
Merged
nreese added a commit that referenced this pull request Aug 4, 2020
@nreese @elasticmachine
[Maps] convert dynamic icon style to TS (#73903) (#74187)
485f438 
* [Maps] convert dynmaic icon style to TS

* tslint

* fix snapsshot name changes caused by file name changes

* revert change that is not part of PR

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck