Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Security Solution][Lists] - Tests cleanup and remove unnecessary import (#73865) #73905

Merged
merged 1 commit into from
Jul 31, 2020
Merged

[7.x] [Security Solution][Lists] - Tests cleanup and remove unnecessary import (#73865) #73905

merged 1 commit into from
Jul 31, 2020

Commits on Jul 30, 2020

  1. [Security Solution][Lists] - Tests cleanup and remove unnecessary imp… 

    …ort (elastic#73865)

## Summary

Addresses feedback from elastic#72748

- Updates `plugins/lists` tests text from `should not validate` to `should FAIL validation` after feedback that previous text is a bit confusing and can be interpreted to mean that validation is not conducted
- Remove unnecessary spreads from one of my late night PRs
- Removes `siem_common_deps` in favor of `shared_imports` in `plugins/lists`
- Updates `build_exceptions_query.test.ts` to use existing mocks
    @yctercero
    yctercero committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    1cf30bb View commit details
    Browse the repository at this point in the history