Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Migrate to React BrowserRouter and Kibana provided History. (#71941) #73919

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

walterra
Copy link
Contributor

Backports the following commits to 7.x:

…stic#71941)

- Migrate to React BrowserRouter and Kibana provided History including a fallback to redirect legacy hash based URLs.
- Migrate breadcrumbs away from hash based URLs.
- Make sure relative custom urls still work after migration.
@walterra walterra self-assigned this Jul 31, 2020
@walterra walterra added the :ml label Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ml 1225 +1 1224

page load bundle size

id value diff baseline
ml 4.3MB +9.8KB 4.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 8c488ac into elastic:7.x Jul 31, 2020
@walterra walterra deleted the backport/7.x/pr-71941 branch July 31, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants