Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix unexpected redirect #73969

Merged
merged 2 commits into from
Jul 31, 2020
Merged

[Security Solution] Fix unexpected redirect #73969

merged 2 commits into from
Jul 31, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jul 31, 2020 •
edited
Loading

Summary

This PR is to fix
https://github.com/elastic/siem-team/issues/820

How to verify this PR:

  1. Check all the cases listed in the issue works correctly.
  2. Go to timelines' page, clicking on templates > Elastib / Custom and see if it lands correctly as well.
  3. On timelines' page, open the flyout, click on the gear, select open timeline, click on every tab. No redirect should happen.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@angorayc angorayc requested review from a team as code owners July 31, 2020 16:13
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:SIEM v7.9.0 v8.0.0 labels Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Jul 31, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +196.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

patrykkopycinski
patrykkopycinski approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything is working as expected. Thank you @angorayc 💪

@patrykkopycinski patrykkopycinski merged commit 2c71a3f into elastic:master Jul 31, 2020
@patrykkopycinski patrykkopycinski deleted the issue-820 branch July 31, 2020 21:17
patrykkopycinski added a commit to angorayc/kibana that referenced this pull request Jul 31, 2020
@angorayc @patrykkopycinski
[Security Solution] Fix unexpected redirect (elastic#73969)
914e209 
* fix unexpected redirect

* fix types

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 31, 2020
Merged
patrykkopycinski added a commit to angorayc/kibana that referenced this pull request Jul 31, 2020
@angorayc @patrykkopycinski
[Security Solution] Fix unexpected redirect (elastic#73969)
4985589 
* fix unexpected redirect

* fix types

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 31, 2020
Merged
patrykkopycinski added a commit that referenced this pull request Jul 31, 2020
@patrykkopycinski @angorayc
[Security Solution] Fix unexpected redirect (#73969) (#74014)
7db66aa 
* fix unexpected redirect

* fix types

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
patrykkopycinski added a commit that referenced this pull request Jul 31, 2020
@patrykkopycinski @angorayc
[Security Solution] Fix unexpected redirect (#73969) (#74015)
8a0bdbf 
* fix unexpected redirect

* fix types

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
@angorayc
Copy link
Contributor Author

angorayc commented Aug 1, 2020

Thanks a lot for taking care of this @patrykkopycinski !!

gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibanamachine @patrykkopycinski @MindyRS