-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API Keys functional test in cloud #74075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
force-pushed
the
ftr/fix-cloud-tests
branch
from
August 3, 2020 15:31
21654bf
to
c1a272b
Compare
dmlemeshko
changed the title
Fix functional test in cloud
Fix API Keys functional test in cloud
Aug 3, 2020
dmlemeshko
added
v7.9.1
v8.0.0
v7.10.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
Aug 3, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
rashmivkulkarni
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good logical improvements. Ran it locally by pulling this branch down. works.
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Aug 3, 2020
* check admin description * split test logic
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Aug 3, 2020
* check admin description * split test logic
dmlemeshko
added a commit
that referenced
this pull request
Aug 4, 2020
dmlemeshko
added a commit
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #72192
Since we run tests on cloud in different order and there is still a chance that API Keys table has data, I splitted test logic.