Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API Keys functional test in cloud #74075

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Aug 3, 2020

Summary

Closes #72192

Since we run tests on cloud in different order and there is still a chance that API Keys table has data, I splitted test logic.

@dmlemeshko dmlemeshko force-pushed the ftr/fix-cloud-tests branch from 21654bf to c1a272b Compare August 3, 2020 15:31
@dmlemeshko dmlemeshko changed the title Fix functional test in cloud Fix API Keys functional test in cloud Aug 3, 2020
@dmlemeshko dmlemeshko added v7.9.1 v8.0.0 v7.10.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 3, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko marked this pull request as ready for review August 3, 2020 17:34
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good logical improvements. Ran it locally by pulling this branch down. works.

@dmlemeshko dmlemeshko merged commit 18e2daa into elastic:master Aug 3, 2020
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Aug 3, 2020
* check admin description

* split test logic
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Aug 3, 2020
* check admin description

* split test logic
dmlemeshko added a commit that referenced this pull request Aug 4, 2020
* check admin description

* split test logic
dmlemeshko added a commit that referenced this pull request Aug 4, 2020
* check admin description

* split test logic
@dmlemeshko dmlemeshko deleted the ftr/fix-cloud-tests branch January 31, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.1 v7.10.0 v8.0.0
Projects
None yet
3 participants