Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change / to \ for Windows Enrollment command in Fleet #74132

Merged

Conversation

EricDavisX
Copy link
Contributor

Summary

Follow up to #73932
...about the Enrollment Flyout text for windows section.

This pr changes the enrollment command / to a \ to be more appropriate (tho it works with the / slash because Windows powershell app is savvy).

So its purely cosmetic, but many folks have noted and asked about it (not aware that it would work in this 'incorrect' citation for windows - it will be a nice peace-of-mind fix for users who know Windows well.

@EricDavisX EricDavisX requested a review from a team August 3, 2020 17:49
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@EricDavisX EricDavisX changed the title 73932-follow-up-on-enrollment-flyout Change / to \ for Windows Enrollment command in Fleet Aug 3, 2020
@EricDavisX EricDavisX added the release_note:skip Skip the PR/issue when compiling release notes label Aug 3, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestManager 1.1MB -1.0B 1.1MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@EricDavisX
Copy link
Contributor Author

all prs are merged and backports as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants