[Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests #74250

yctercero · 2020-08-04T13:47:45Z

Summary

Updates logic for deleting exception item entries in the builder - found that there was a bug in deleting nested entries
Adds more unit tests

Bug

Fix

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

yctercero · 2020-08-04T13:51:07Z

x-pack/plugins/security_solution/public/common/components/exceptions/builder/entry_item.tsx

@@ -34,7 +34,6 @@ interface EntryItemProps {
  indexPattern: IIndexPattern;
  showLabel: boolean;
  listType: ExceptionListType;
-  addNested: boolean;


Wasn't being used anywhere.

…delete

elasticmachine · 2020-08-04T15:38:21Z

Pinging @elastic/siem (Team:SIEM)

peluja1012

Thanks for finding and fixing this deletion bug! Pulled down the branch and verified the bug is fixed. LGTM.

yctercero · 2020-08-04T19:43:13Z

Updated tags to include 7.9 as this was deemed a necessary bug fix to be backported.

x-pack/plugins/security_solution/public/common/components/exceptions/builder/and_badge.tsx

rylnd

Had a few nits but this looks to be working as I expect it to. I don't have as much experience with this UI, though, so I defer to @madirey and @peluja1012 here.

x-pack/plugins/security_solution/public/common/components/exceptions/builder/and_badge.tsx

x-pack/plugins/security_solution/public/common/components/exceptions/builder/and_badge.test.tsx

rylnd · 2020-08-04T19:53:40Z

...lugins/security_solution/public/common/components/exceptions/builder/entry_delete_button.tsx

+    );
+
+    if (entryIndex === 0 && exceptionItemIndex === 0 && nestedParentIndex == null) {
+      // This logic was added to work around it including the field


Could this be accomplished in CSS with e.g. a :first-of-type selector?

Yes, most likely! I've jotted down to follow up on. Thanks!

x-pack/plugins/security_solution/public/common/components/exceptions/builder/helpers.tsx

x-pack/plugins/security_solution/public/common/components/exceptions/builder/index.test.tsx

kibanamachine · 2020-08-04T23:34:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 13edaa6

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	2028	+2	2026

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+535.0B	7.3MB

History

💚 Build #66411 succeeded 3fda1e2
💚 Build #66397 succeeded ac88cdb
💚 Build #66381 succeeded 393d08b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…etion issue and adds unit tests (elastic#74250) ### Summary - Updates logic for deleting exception item entries in the builder - found that there was a bug in deleting nested entries - Adds more unit tests

…etion issue and adds unit tests (#74250) (#74322) ### Summary - Updates logic for deleting exception item entries in the builder - found that there was a bug in deleting nested entries - Adds more unit tests

* master: (74 commits) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) [kbn/optimizer] remove unused modules (elastic#74195) [CI] Add pipeline task queue framework and merge workers into one (elastic#71268) Using msearch for tree api endpoint (elastic#73813) ...

* master: (115 commits) [Logs UI] Correct trial period duration in anomaly splash screen (elastic#74249) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) [kbn/optimizer] remove unused modules (elastic#74195) [CI] Add pipeline task queue framework and merge workers into one (elastic#71268) ...

…etion issue and adds unit tests (#74250) (#74321) ### Summary - Updates logic for deleting exception item entries in the builder - found that there was a bug in deleting nested entries - Adds more unit tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (154 commits) [ML] Fix initial plugin's bundle size (elastic#74047) [Ingest Manager] prevent crash on unhandled rejection from setupIngestManager (elastic#74300) [Logs UI] Correct trial period duration in anomaly splash screen (elastic#74249) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) ...

elasticmachine · 2021-09-23T14:27:35Z

Pinging @elastic/security-solution (Team: SecuritySolution)

cleaned up exceptions builder and added tests

393d08b

yctercero commented Aug 4, 2020

View reviewed changes

yctercero changed the title ~~cleaned up exceptions builder and added tests~~ [Security Solution][Exceptions] - Cleans up exceptions builder and adds unit tests Aug 4, 2020

yctercero self-assigned this Aug 4, 2020

yctercero added 7.10.0 Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:enhancement Team:SIEM v7.9.1 v8.0.0 labels Aug 4, 2020

updated stories

ac88cdb

tylersmalley added v7.10.0 and removed 7.10.0 labels Aug 4, 2020

yctercero added the release_note:fix label Aug 4, 2020

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

3fda1e2

…delete

yctercero marked this pull request as ready for review August 4, 2020 15:38

yctercero requested review from a team as code owners August 4, 2020 15:38

yctercero changed the title ~~[Security Solution][Exceptions] - Cleans up exceptions builder and adds unit tests~~ [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests Aug 4, 2020

peluja1012 approved these changes Aug 4, 2020

View reviewed changes

yctercero added v7.9.0 and removed v7.9.1 labels Aug 4, 2020

peluja1012 reviewed Aug 4, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/exceptions/builder/and_badge.tsx Outdated Show resolved Hide resolved

rylnd approved these changes Aug 4, 2020

View reviewed changes

yctercero removed the release_note:enhancement label Aug 4, 2020

applied PR feedback

13edaa6

yctercero merged commit 6a77bec into elastic:master Aug 5, 2020

yctercero mentioned this pull request Aug 5, 2020

[7.x] [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (#74250) #74321

Merged

yctercero mentioned this pull request Aug 5, 2020

[7.9] [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (#74250) #74322

Merged

yctercero deleted the exceptions_delete branch October 14, 2020 12:01

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests #74250

[Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests #74250

yctercero commented Aug 4, 2020 •

edited

Loading

yctercero Aug 4, 2020

elasticmachine commented Aug 4, 2020

peluja1012 left a comment

yctercero commented Aug 4, 2020

rylnd left a comment

rylnd Aug 4, 2020

yctercero Aug 4, 2020

kibanamachine commented Aug 4, 2020

elasticmachine commented Sep 23, 2021

[Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests #74250

[Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests #74250

Conversation

yctercero commented Aug 4, 2020 • edited Loading

Summary

Bug

Fix

Checklist

yctercero Aug 4, 2020

Choose a reason for hiding this comment

elasticmachine commented Aug 4, 2020

peluja1012 left a comment

Choose a reason for hiding this comment

yctercero commented Aug 4, 2020

rylnd left a comment

Choose a reason for hiding this comment

rylnd Aug 4, 2020

Choose a reason for hiding this comment

yctercero Aug 4, 2020

Choose a reason for hiding this comment

kibanamachine commented Aug 4, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

History

elasticmachine commented Sep 23, 2021

yctercero commented Aug 4, 2020 •

edited

Loading