Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Fix/DRY out plugin i18n strings #74323

Merged
merged 4 commits into from
Aug 5, 2020
Merged

[Enterprise Search] Fix/DRY out plugin i18n strings #74323

merged 4 commits into from
Aug 5, 2020

Commits on Aug 5, 2020

  1. i18n refactor 

    - DRY out plugin details to constants and correctly i18n-ize front-end-facing strings
    @cee-chen
    cee-chen committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    862c692 View commit details
    Browse the repository at this point in the history

  2. DRY out new i18n constants 

    - refactor instances of i18n.translate to use new constants
    @cee-chen
    cee-chen committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    be7d214 View commit details
    Browse the repository at this point in the history

  3. Fix non-i18n'd breadcrumb strings

    @cee-chen
    cee-chen committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    3a61a3d View commit details
    Browse the repository at this point in the history

  4. PR feedback: swap out more plugin ID strings for constants

    @cee-chen
    cee-chen committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a429f85 View commit details
    Browse the repository at this point in the history