Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.9] [ML] Fix initial plugin's bundle size (#74047) #74361

Closed
wants to merge 1 commit into from
Closed

[7.9] [ML] Fix initial plugin's bundle size (#74047) #74361

wants to merge 1 commit into from

Conversation

darnautov
Copy link
Contributor

Backports the following commits to 7.9:

@darnautov
[ML] Fix initial plugin's bundle size (elastic#74047)
a6d1402 
* [ML] use dynamic imports

* [ML] fix react-use imports

* [ML] change embeddables imports

* [ML] embeddable exports

* [ML] move SCSS import

* [ML] management page styles

* [ML] refactor with types and constants files

* [ML] move declarations
@darnautov darnautov self-assigned this Aug 5, 2020
@darnautov darnautov added the :ml label Aug 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ml 278 -113 391

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tylersmalley
tylersmalley suggested changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid backporting this to 7.9. This optimization can go out in 7.10.

@darnautov darnautov closed this Aug 5, 2020
@darnautov darnautov deleted the backport/7.9/pr-74047 branch August 5, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley requested changes

Assignees

@darnautov darnautov

Labels
backport :ml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @kibanamachine @tylersmalley @peteharverson