Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY_SOLUTION] add z-index to get over nav bar #74427

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Aug 5, 2020

Summary

Fixes a critical issue where the nav bar was rendered in front of the Host flyout. This corrects that by added a greater z-index, similar to the timeline flyout.

BEFORE:
image

AFTER:
image

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kevinlog kevinlog requested review from a team as code owners August 5, 2020 20:29
@kevinlog kevinlog added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.10.0 v8.0.0 labels Aug 5, 2020
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine for 7.9.

Maybe some before/after screenshots for the main PR comment would be nice

And we should file a backlog ticket for generalizing this for all flyouts on the page

<EuiFlyout onClose={handleFlyoutClose} data-test-subj="hostDetailsFlyout" size="s">
<EuiFlyout
onClose={handleFlyoutClose}
style={{ zIndex: 4001 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a very interesting fix

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@charlie-pichette charlie-pichette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<EuiFlyout onClose={handleFlyoutClose} data-test-subj="hostDetailsFlyout" size="s">
<EuiFlyout
onClose={handleFlyoutClose}
style={{ zIndex: 4001 }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a very interesting fix

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/task_manager_integration·js.task_manager scheduling and running tasks should return a task run error result when trying to run a task now which is already running

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/71390

[00:00:00]       │
[00:00:00]         └-: task_manager
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: scheduling and running tasks
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should support middleware
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               └-> "before each" hook
[00:00:00]               └-> "before each" hook
[00:00:00]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1596659948632887514] [.kibana_task_manager_test_result] creating index, cause [api], templates [], shards [1]/[1]
[00:00:00]               │ debg Task created: 2ff215b0-d763-11ea-9051-a1644437b7c9
[00:00:00]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:00]               │ proc [kibana]   log   [21:32:39.540] [warning][plugins][reporting] Enabling the Chromium sandbox provides an additional layer of protection.
[00:00:00]               │ debg --- retry.try failed again with the same message...
[00:00:01]               │ debg --- retry.try failed again with the same message...
[00:00:01]               │ debg --- retry.try failed again with the same message...
[00:00:02]               │ debg --- retry.try failed again with the same message...
[00:00:02]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1596659948632887514] [.kibana_task_manager_test_result/WD346kKmQqW3NQB44xPtKA] update_mapping [_doc]
[00:00:02]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1596659948632887514] [ilm-history-2-000001] creating index, cause [api], templates [ilm-history], shards [1]/[0]
[00:00:02]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1596659948632887514] moving index [ilm-history-2-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:02]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1596659948632887514] moving index [ilm-history-2-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [ilm-history-ilm-policy]
[00:00:02]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1596659948632887514] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [ilm-history-ilm-policy]
[00:00:02]               │ debg Task found: 2ff215b0-d763-11ea-9051-a1644437b7c9
[00:00:02]               │ debg Task status: claiming
[00:00:02]               │ debg Task state: {}
[00:00:02]               │ debg Task params: {
[00:00:02]               │        "originalParams": {
[00:00:02]               │          "historyItem": 55
[00:00:02]               │        },
[00:00:02]               │        "superFly": "My middleware param!"
[00:00:02]               │      }
[00:00:02]               │ debg --- retry.try error: expected undefined to sort of equal 1
[00:00:03]               │ debg Task found: 2ff215b0-d763-11ea-9051-a1644437b7c9
[00:00:03]               │ debg Task status: idle
[00:00:03]               │ debg Task state: {
[00:00:03]               │        "count": 1
[00:00:03]               │      }
[00:00:03]               │ debg Task params: {
[00:00:03]               │        "originalParams": {
[00:00:03]               │          "historyItem": 55
[00:00:03]               │        },
[00:00:03]               │        "superFly": "My middleware param!"
[00:00:03]               │      }
[00:00:03]               └- ✓ pass  (3.2s) "task_manager scheduling and running tasks should support middleware"
[00:00:03]             └-> should remove non-recurring tasks after they complete
[00:00:03]               └-> "before each" hook: global before each
[00:00:03]               └-> "before each" hook
[00:00:04]               └-> "before each" hook
[00:00:04]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:05]               │ debg --- retry.try failed again with the same message...
[00:00:05]               │ debg --- retry.try failed again with the same message...
[00:00:06]               │ debg --- retry.try failed again with the same message...
[00:00:06]               │ debg --- retry.try failed again with the same message...
[00:00:07]               │ debg --- retry.try failed again with the same message...
[00:00:07]               │ debg --- retry.try failed again with the same message...
[00:00:08]               │ debg --- retry.try failed again with the same message...
[00:00:08]               │ debg --- retry.try error: expected [ { taskType: 'sampleTask',
[00:00:08]               │          retryAt: '2020-08-05T21:33:17.535Z',
[00:00:08]               │          runAt: '2020-08-05T21:32:43.644Z',
[00:00:08]               │          scope: [ 'testing' ],
[00:00:08]               │          startedAt: null,
[00:00:08]               │          state: {},
[00:00:08]               │          params: 
[00:00:08]               │           { originalParams: {},
[00:00:08]               │             superFly: 'My middleware param!' },
[00:00:08]               │          ownerId: 'kibana:5b2de169-2785-441b-ae8c-186a1936b17d',
[00:00:08]               │          scheduledAt: '2020-08-05T21:32:43.644Z',
[00:00:08]               │          attempts: 0,
[00:00:08]               │          status: 'claiming',
[00:00:08]               │          id: '32747ad0-d763-11ea-9051-a1644437b7c9' } ] to sort of equal []
[00:00:09]               │ debg --- retry.try failed again with the same message...
[00:00:09]               └- ✓ pass  (5.2s) "task_manager scheduling and running tasks should remove non-recurring tasks after they complete"
[00:00:09]             └-> should use a given ID as the task document ID
[00:00:09]               └-> "before each" hook: global before each
[00:00:09]               └-> "before each" hook
[00:00:09]               └-> "before each" hook
[00:00:09]               └- ✓ pass  (21ms) "task_manager scheduling and running tasks should use a given ID as the task document ID"
[00:00:09]             └-> should allow a task with a given ID to be scheduled multiple times
[00:00:09]               └-> "before each" hook: global before each
[00:00:09]               └-> "before each" hook
[00:00:09]               └-> "before each" hook
[00:00:09]               │ proc [kibana]   log   [21:32:48.970] [error][data][elasticsearch] [version_conflict_engine_exception]: [task:test-task-to-reschedule-in-task-manager]: version conflict, document already exists (current version [1])
[00:00:09]               └- ✓ pass  (39ms) "task_manager scheduling and running tasks should allow a task with a given ID to be scheduled multiple times"
[00:00:09]             └-> should reschedule if task errors
[00:00:09]               └-> "before each" hook: global before each
[00:00:09]               └-> "before each" hook
[00:00:09]               └-> "before each" hook
[00:00:09]               │ debg --- retry.try error: Cannot read property 'id' of undefined
[00:00:10]               │ debg --- retry.try failed again with the same message...
[00:00:10]               │ debg --- retry.try error: expected 'test-task-for-sample-task-plugin-to-test-task-manager' to sort of equal '35a74430-d763-11ea-9051-a1644437b7c9'
[00:00:11]               │ debg --- retry.try failed again with the same message...
[00:00:11]               │ proc [kibana]   log   [21:32:50.680] [error][plugins][taskManager][taskManager] Task sampleTask "35a74430-d763-11ea-9051-a1644437b7c9" failed: Error: Dangit!!!!!
[00:00:12]               │ debg --- retry.try failed again with the same message...
[00:00:12]               │ debg --- retry.try failed again with the same message...
[00:00:13]               └- ✓ pass  (3.2s) "task_manager scheduling and running tasks should reschedule if task errors"
[00:00:13]             └-> should reschedule if task returns runAt
[00:00:13]               └-> "before each" hook: global before each
[00:00:13]               └-> "before each" hook
[00:00:13]               └-> "before each" hook
[00:00:13]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:14]               │ debg --- retry.try failed again with the same message...
[00:00:14]               │ debg --- retry.try failed again with the same message...
[00:00:15]               │ debg --- retry.try failed again with the same message...
[00:00:15]               │ debg --- retry.try failed again with the same message...
[00:00:16]               │ debg --- retry.try failed again with the same message...
[00:00:16]               │ debg --- retry.try failed again with the same message...
[00:00:17]               │ debg --- retry.try failed again with the same message...
[00:00:17]               │ debg --- retry.try error: expected 1 to sort of equal 0
[00:00:18]               │ debg --- retry.try failed again with the same message...
[00:00:18]               └- ✓ pass  (5.2s) "task_manager scheduling and running tasks should reschedule if task returns runAt"
[00:00:18]             └-> should reschedule if task has an interval
[00:00:18]               └-> "before each" hook: global before each
[00:00:18]               └-> "before each" hook
[00:00:19]               └-> "before each" hook
[00:00:19]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:20]               │ debg --- retry.try failed again with the same message...
[00:00:20]               │ debg --- retry.try failed again with the same message...
[00:00:21]               │ debg --- retry.try failed again with the same message...
[00:00:21]               │ debg --- retry.try failed again with the same message...
[00:00:22]               │ debg --- retry.try failed again with the same message...
[00:00:22]               │ debg --- retry.try failed again with the same message...
[00:00:23]               │ debg --- retry.try failed again with the same message...
[00:00:23]               └- ✓ pass  (4.1s) "task_manager scheduling and running tasks should reschedule if task has an interval"
[00:00:23]             └-> should support the deprecated interval field
[00:00:23]               └-> "before each" hook: global before each
[00:00:23]               └-> "before each" hook
[00:00:24]               └-> "before each" hook
[00:00:24]               │ proc [kibana]   log   [21:33:03.965] [warning][plugins][taskManager][taskManager] Task of type "sampleTask" has been scheduled with the deprecated 'interval' field which is due to be removed in a future release
[00:00:24]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:25]               │ debg --- retry.try failed again with the same message...
[00:00:25]               │ debg --- retry.try failed again with the same message...
[00:00:26]               │ debg --- retry.try failed again with the same message...
[00:00:26]               └- ✓ pass  (2.1s) "task_manager scheduling and running tasks should support the deprecated interval field"
[00:00:26]             └-> should return a task run result when asked to run a task now
[00:00:26]               └-> "before each" hook: global before each
[00:00:26]               └-> "before each" hook
[00:00:27]               └-> "before each" hook
[00:00:27]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:28]               │ debg --- retry.try failed again with the same message...
[00:00:28]               │ debg --- retry.try failed again with the same message...
[00:00:29]               │ debg --- retry.try failed again with the same message...
[00:00:30]               │ debg --- retry.try error: expected 1 to sort of equal 2
[00:00:30]               │ debg --- retry.try failed again with the same message...
[00:00:31]               └- ✓ pass  (3.4s) "task_manager scheduling and running tasks should return a task run result when asked to run a task now"
[00:00:31]             └-> should prioritize tasks which are called using runNow
[00:00:31]               └-> "before each" hook: global before each
[00:00:31]               └-> "before each" hook
[00:00:31]               └-> "before each" hook
[00:00:32]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:32]               │ debg --- retry.try failed again with the same message...
[00:00:33]               │ debg --- retry.try failed again with the same message...
[00:00:33]               │ debg --- retry.try failed again with the same message...
[00:00:34]               │ debg --- retry.try failed again with the same message...
[00:00:34]               │ debg --- retry.try failed again with the same message...
[00:00:35]               │ debg --- retry.try failed again with the same message...
[00:00:35]               │ debg --- retry.try failed again with the same message...
[00:00:44]               │ debg --- retry.try error: expected 10 to sort of equal 0
[00:00:45]               │ debg --- retry.try error: expected 9 to sort of equal 0
[00:00:45]               │ debg --- retry.try failed again with the same message...
[00:00:46]               │ debg --- retry.try failed again with the same message...
[00:00:46]               │ debg --- retry.try failed again with the same message...
[00:00:47]               │ debg --- retry.try failed again with the same message...
[00:00:47]               │ debg --- retry.try failed again with the same message...
[00:00:48]               │ debg --- retry.try failed again with the same message...
[00:00:48]               │ debg --- retry.try failed again with the same message...
[00:00:49]               └- ✓ pass  (17.5s) "task_manager scheduling and running tasks should prioritize tasks which are called using runNow"
[00:00:49]             └-> should return a task run error result when running a task now fails
[00:00:49]               └-> "before each" hook: global before each
[00:00:49]               └-> "before each" hook
[00:00:50]               └-> "before each" hook
[00:00:50]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:50]               │ debg --- retry.try failed again with the same message...
[00:00:51]               │ debg --- retry.try failed again with the same message...
[00:00:52]               │ debg --- retry.try failed again with the same message...
[00:00:52]               │ debg --- retry.try failed again with the same message...
[00:00:53]               │ debg --- retry.try failed again with the same message...
[00:00:53]               │ debg --- retry.try failed again with the same message...
[00:00:54]               │ proc [kibana]   log   [21:33:33.748] [error][plugins][taskManager][taskManager] Task sampleTask "4dd6ac30-d763-11ea-9051-a1644437b7c9" failed: Error: this task was meant to fail!
[00:00:54]               └- ✓ pass  (4.3s) "task_manager scheduling and running tasks should return a task run error result when running a task now fails"
[00:00:54]             └-> should return a task run error result when trying to run a non-existent task
[00:00:54]               └-> "before each" hook: global before each
[00:00:54]               └-> "before each" hook
[00:00:55]               └-> "before each" hook
[00:00:55]               └- ✓ pass  (25ms) "task_manager scheduling and running tasks should return a task run error result when trying to run a non-existent task"
[00:00:55]             └-> should return a task run error result when trying to run a task now which is already running
[00:00:55]               └-> "before each" hook: global before each
[00:00:55]               └-> "before each" hook
[00:00:55]               └-> "before each" hook
[00:00:55]               │ debg --- retry.try error: Cannot read property 'status' of undefined
[00:00:56]               │ debg --- retry.try failed again with the same message...
[00:00:56]               │ debg --- retry.try error: expected 'idle' to sort of equal 'running'
[00:00:57]               │ debg --- retry.try failed again with the same message...
[00:00:57]               │ debg --- retry.try failed again with the same message...
[00:00:58]               │ debg --- retry.try failed again with the same message...
[00:00:58]               │ debg --- retry.try failed again with the same message...
[00:00:59]               │ debg --- retry.try failed again with the same message...
[00:00:59]               │ debg --- retry.try error: expected 'claiming' to sort of equal 'running'
[00:01:00]               │ debg --- retry.try failed again with the same message...
[00:01:00]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:01:01]               │ proc [kibana]   log   [21:33:40.442] [warning][plugins][taskManager][taskManager] [Task Ownership error]: 1 tasks were claimed by Kibana, but 2 task(s) were fetched (endpoint:user-artifact-packager:1.0.0, 50d85370-d763-11ea-9051-a1644437b7c9)
[00:01:01]               │ debg --- retry.try error: expected undefined to sort of equal 1
[00:01:01]               │ debg --- retry.try error: expected 'idle' to sort of equal 'running'
[00:01:02]               │ debg --- retry.try failed again with the same message...
[00:01:02]               │ debg --- retry.try failed again with the same message...
[00:01:03]               │ debg --- retry.try failed again with the same message...
[00:01:03]               │ debg --- retry.try failed again with the same message...
[00:01:04]               │ debg --- retry.try failed again with the same message...
[00:01:05]               │ debg --- retry.try failed again with the same message...
[00:01:05]               │ debg --- retry.try failed again with the same message...
[00:01:06]               │ debg --- retry.try failed again with the same message...
[00:01:06]               │ debg --- retry.try failed again with the same message...
[00:01:07]               │ debg --- retry.try failed again with the same message...
[00:01:07]               │ debg --- retry.try failed again with the same message...
[00:01:08]               │ debg --- retry.try failed again with the same message...
[00:01:08]               │ debg --- retry.try failed again with the same message...
[00:01:09]               │ debg --- retry.try failed again with the same message...
[00:01:09]               │ debg --- retry.try failed again with the same message...
[00:01:10]               │ debg --- retry.try failed again with the same message...
[00:01:10]               │ debg --- retry.try failed again with the same message...
[00:01:11]               │ debg --- retry.try failed again with the same message...
[00:01:11]               │ debg --- retry.try failed again with the same message...
[00:01:12]               │ debg --- retry.try failed again with the same message...
[00:01:12]               │ debg --- retry.try failed again with the same message...
[00:01:13]               │ debg --- retry.try failed again with the same message...
[00:01:13]               │ debg --- retry.try failed again with the same message...
[00:01:14]               │ debg --- retry.try failed again with the same message...
[00:01:14]               │ debg --- retry.try failed again with the same message...
[00:01:15]               │ debg --- retry.try failed again with the same message...
[00:01:15]               │ debg --- retry.try failed again with the same message...
[00:01:16]               │ debg --- retry.try failed again with the same message...
[00:01:16]               │ debg --- retry.try failed again with the same message...
[00:01:17]               │ debg --- retry.try failed again with the same message...
[00:01:17]               │ debg --- retry.try failed again with the same message...
[00:01:18]               │ debg --- retry.try failed again with the same message...
[00:01:19]               │ debg --- retry.try failed again with the same message...
[00:01:19]               │ debg --- retry.try failed again with the same message...
[00:01:20]               │ debg --- retry.try failed again with the same message...
[00:01:20]               │ debg --- retry.try failed again with the same message...
[00:01:21]               │ debg --- retry.try failed again with the same message...
[00:01:21]               │ debg --- retry.try failed again with the same message...
[00:01:22]               │ debg --- retry.try failed again with the same message...
[00:01:22]               │ debg --- retry.try failed again with the same message...
[00:01:23]               │ debg --- retry.try failed again with the same message...
[00:01:23]               │ debg --- retry.try failed again with the same message...
[00:01:24]               │ debg --- retry.try failed again with the same message...
[00:01:24]               │ debg --- retry.try failed again with the same message...
[00:01:25]               │ debg --- retry.try failed again with the same message...
[00:01:25]               │ debg --- retry.try failed again with the same message...
[00:01:26]               │ debg --- retry.try failed again with the same message...
[00:01:26]               │ debg --- retry.try failed again with the same message...
[00:01:27]               │ debg --- retry.try failed again with the same message...
[00:01:27]               │ debg --- retry.try failed again with the same message...
[00:01:28]               │ debg --- retry.try failed again with the same message...
[00:01:28]               │ debg --- retry.try failed again with the same message...
[00:01:29]               │ debg --- retry.try failed again with the same message...
[00:01:29]               │ debg --- retry.try failed again with the same message...
[00:01:30]               │ debg --- retry.try failed again with the same message...
[00:01:30]               │ debg --- retry.try failed again with the same message...
[00:01:31]               │ debg --- retry.try failed again with the same message...
[00:01:31]               │ debg --- retry.try failed again with the same message...
[00:01:32]               │ debg --- retry.try failed again with the same message...
[00:01:32]               │ debg --- retry.try failed again with the same message...
[00:01:33]               │ debg --- retry.try failed again with the same message...
[00:01:34]               │ debg --- retry.try failed again with the same message...
[00:01:34]               │ debg --- retry.try failed again with the same message...
[00:01:35]               │ debg --- retry.try failed again with the same message...
[00:01:35]               │ debg --- retry.try failed again with the same message...
[00:01:36]               │ debg --- retry.try failed again with the same message...
[00:01:36]               │ debg --- retry.try failed again with the same message...
[00:01:37]               │ debg --- retry.try failed again with the same message...
[00:01:37]               │ debg --- retry.try failed again with the same message...
[00:01:38]               │ debg --- retry.try failed again with the same message...
[00:01:38]               │ debg --- retry.try failed again with the same message...
[00:01:39]               │ debg --- retry.try failed again with the same message...
[00:01:39]               │ debg --- retry.try failed again with the same message...
[00:01:40]               │ debg --- retry.try failed again with the same message...
[00:01:40]               │ debg --- retry.try failed again with the same message...
[00:01:41]               │ debg --- retry.try failed again with the same message...
[00:01:41]               │ debg --- retry.try failed again with the same message...
[00:01:42]               │ debg --- retry.try failed again with the same message...
[00:01:42]               │ debg --- retry.try failed again with the same message...
[00:01:43]               │ debg --- retry.try failed again with the same message...
[00:01:43]               │ debg --- retry.try failed again with the same message...
[00:01:44]               │ debg --- retry.try failed again with the same message...
[00:01:44]               │ debg --- retry.try failed again with the same message...
[00:01:45]               │ debg --- retry.try failed again with the same message...
[00:01:45]               │ debg --- retry.try failed again with the same message...
[00:01:46]               │ debg --- retry.try failed again with the same message...
[00:01:46]               │ debg --- retry.try failed again with the same message...
[00:01:47]               │ debg --- retry.try failed again with the same message...
[00:01:47]               │ debg --- retry.try failed again with the same message...
[00:01:48]               │ debg --- retry.try failed again with the same message...
[00:01:48]               │ debg --- retry.try failed again with the same message...
[00:01:49]               │ debg --- retry.try failed again with the same message...
[00:01:50]               │ debg --- retry.try failed again with the same message...
[00:01:50]               │ debg --- retry.try failed again with the same message...
[00:01:51]               │ debg --- retry.try failed again with the same message...
[00:01:51]               │ debg --- retry.try failed again with the same message...
[00:01:52]               │ debg --- retry.try failed again with the same message...
[00:01:52]               │ debg --- retry.try failed again with the same message...
[00:01:53]               │ debg --- retry.try failed again with the same message...
[00:01:53]               │ debg --- retry.try failed again with the same message...
[00:01:54]               │ debg --- retry.try failed again with the same message...
[00:01:54]               │ debg --- retry.try failed again with the same message...
[00:01:55]               │ debg --- retry.try failed again with the same message...
[00:01:55]               │ debg --- retry.try failed again with the same message...
[00:01:56]               │ debg --- retry.try failed again with the same message...
[00:01:56]               │ debg --- retry.try failed again with the same message...
[00:01:57]               │ debg --- retry.try failed again with the same message...
[00:01:57]               │ debg --- retry.try failed again with the same message...
[00:01:58]               │ debg --- retry.try failed again with the same message...
[00:01:58]               │ debg --- retry.try failed again with the same message...
[00:01:59]               │ debg --- retry.try failed again with the same message...
[00:01:59]               │ debg --- retry.try failed again with the same message...
[00:02:00]               │ debg --- retry.try failed again with the same message...
[00:02:00]               │ debg --- retry.try failed again with the same message...
[00:02:01]               │ debg --- retry.try failed again with the same message...
[00:02:01]               │ debg --- retry.try failed again with the same message...
[00:02:02]               │ debg --- retry.try failed again with the same message...
[00:02:02]               │ debg --- retry.try failed again with the same message...
[00:02:03]               │ debg --- retry.try failed again with the same message...
[00:02:03]               │ debg --- retry.try failed again with the same message...
[00:02:04]               │ debg --- retry.try failed again with the same message...
[00:02:04]               │ debg --- retry.try failed again with the same message...
[00:02:05]               │ debg --- retry.try failed again with the same message...
[00:02:06]               │ debg --- retry.try failed again with the same message...
[00:02:06]               │ debg --- retry.try failed again with the same message...
[00:02:07]               │ debg --- retry.try failed again with the same message...
[00:02:07]               │ debg --- retry.try failed again with the same message...
[00:02:08]               │ debg --- retry.try failed again with the same message...
[00:02:08]               │ debg --- retry.try failed again with the same message...
[00:02:09]               │ debg --- retry.try failed again with the same message...
[00:02:09]               │ debg --- retry.try failed again with the same message...
[00:02:10]               │ debg --- retry.try failed again with the same message...
[00:02:10]               │ debg --- retry.try failed again with the same message...
[00:02:11]               │ debg --- retry.try failed again with the same message...
[00:02:11]               │ debg --- retry.try failed again with the same message...
[00:02:12]               │ debg --- retry.try failed again with the same message...
[00:02:12]               │ debg --- retry.try failed again with the same message...
[00:02:13]               │ debg --- retry.try failed again with the same message...
[00:02:13]               │ debg --- retry.try failed again with the same message...
[00:02:14]               │ debg --- retry.try failed again with the same message...
[00:02:14]               │ debg --- retry.try failed again with the same message...
[00:02:15]               │ debg --- retry.try failed again with the same message...
[00:02:15]               │ debg --- retry.try failed again with the same message...
[00:02:16]               │ debg --- retry.try failed again with the same message...
[00:02:16]               │ debg --- retry.try failed again with the same message...
[00:02:17]               │ debg --- retry.try failed again with the same message...
[00:02:17]               │ debg --- retry.try failed again with the same message...
[00:02:18]               │ debg --- retry.try failed again with the same message...
[00:02:18]               │ debg --- retry.try failed again with the same message...
[00:02:19]               │ debg --- retry.try failed again with the same message...
[00:02:19]               │ debg --- retry.try failed again with the same message...
[00:02:20]               │ debg --- retry.try failed again with the same message...
[00:02:20]               │ debg --- retry.try failed again with the same message...
[00:02:21]               │ debg --- retry.try failed again with the same message...
[00:02:21]               │ debg --- retry.try failed again with the same message...
[00:02:22]               │ debg --- retry.try failed again with the same message...
[00:02:23]               │ debg --- retry.try failed again with the same message...
[00:02:23]               │ debg --- retry.try failed again with the same message...
[00:02:24]               │ debg --- retry.try failed again with the same message...
[00:02:24]               │ debg --- retry.try failed again with the same message...
[00:02:25]               │ debg --- retry.try failed again with the same message...
[00:02:25]               │ debg --- retry.try failed again with the same message...
[00:02:26]               │ debg --- retry.try failed again with the same message...
[00:02:26]               │ debg --- retry.try failed again with the same message...
[00:02:27]               │ debg --- retry.try failed again with the same message...
[00:02:27]               │ debg --- retry.try failed again with the same message...
[00:02:28]               │ debg --- retry.try failed again with the same message...
[00:02:28]               │ debg --- retry.try failed again with the same message...
[00:02:29]               │ debg --- retry.try failed again with the same message...
[00:02:29]               │ debg --- retry.try failed again with the same message...
[00:02:30]               │ debg --- retry.try failed again with the same message...
[00:02:30]               │ debg --- retry.try failed again with the same message...
[00:02:31]               │ debg --- retry.try failed again with the same message...
[00:02:31]               │ debg --- retry.try failed again with the same message...
[00:02:32]               │ debg --- retry.try failed again with the same message...
[00:02:32]               │ debg --- retry.try failed again with the same message...
[00:02:33]               │ debg --- retry.try failed again with the same message...
[00:02:33]               │ debg --- retry.try failed again with the same message...
[00:02:34]               │ debg --- retry.try failed again with the same message...
[00:02:34]               │ debg --- retry.try failed again with the same message...
[00:02:35]               │ debg --- retry.try failed again with the same message...
[00:02:35]               │ debg --- retry.try failed again with the same message...
[00:02:36]               │ debg --- retry.try failed again with the same message...
[00:02:36]               │ debg --- retry.try failed again with the same message...
[00:02:37]               │ debg --- retry.try failed again with the same message...
[00:02:37]               │ debg --- retry.try failed again with the same message...
[00:02:38]               │ debg --- retry.try failed again with the same message...
[00:02:38]               │ debg --- retry.try failed again with the same message...
[00:02:39]               │ debg --- retry.try failed again with the same message...
[00:02:40]               │ debg --- retry.try failed again with the same message...
[00:02:40]               │ debg --- retry.try failed again with the same message...
[00:02:41]               │ debg --- retry.try failed again with the same message...
[00:02:41]               │ debg --- retry.try failed again with the same message...
[00:02:42]               │ debg --- retry.try failed again with the same message...
[00:02:42]               │ debg --- retry.try failed again with the same message...
[00:02:43]               │ debg --- retry.try failed again with the same message...
[00:02:43]               │ debg --- retry.try failed again with the same message...
[00:02:44]               │ debg --- retry.try failed again with the same message...
[00:02:44]               │ debg --- retry.try failed again with the same message...
[00:02:45]               │ debg --- retry.try failed again with the same message...
[00:02:45]               │ debg --- retry.try failed again with the same message...
[00:02:46]               │ debg --- retry.try failed again with the same message...
[00:02:46]               │ debg --- retry.try failed again with the same message...
[00:02:47]               │ debg --- retry.try failed again with the same message...
[00:02:47]               │ debg --- retry.try failed again with the same message...
[00:02:48]               │ debg --- retry.try failed again with the same message...
[00:02:48]               │ debg --- retry.try failed again with the same message...
[00:02:49]               │ debg --- retry.try failed again with the same message...
[00:02:49]               │ debg --- retry.try failed again with the same message...
[00:02:50]               │ debg --- retry.try failed again with the same message...
[00:02:50]               │ debg --- retry.try failed again with the same message...
[00:02:51]               │ debg --- retry.try failed again with the same message...
[00:02:51]               │ debg --- retry.try failed again with the same message...
[00:02:52]               │ debg --- retry.try failed again with the same message...
[00:02:52]               │ debg --- retry.try failed again with the same message...
[00:02:53]               │ debg --- retry.try failed again with the same message...
[00:02:53]               │ debg --- retry.try failed again with the same message...
[00:02:54]               │ debg --- retry.try failed again with the same message...
[00:02:54]               │ debg --- retry.try failed again with the same message...
[00:02:55]               │ debg --- retry.try failed again with the same message...
[00:02:55]               │ debg --- retry.try failed again with the same message...
[00:02:56]               │ debg --- retry.try failed again with the same message...
[00:02:57]               │ debg --- retry.try failed again with the same message...
[00:02:57]               │ debg --- retry.try failed again with the same message...
[00:02:58]               │ debg --- retry.try failed again with the same message...
[00:02:58]               │ debg --- retry.try failed again with the same message...
[00:02:59]               │ debg --- retry.try failed again with the same message...
[00:02:59]               │ debg --- retry.try failed again with the same message...
[00:03:00]               │ debg --- retry.try failed again with the same message...
[00:03:00]               │ debg --- retry.try failed again with the same message...
[00:03:01]               │ debg --- retry.try failed again with the same message...
[00:03:01]               │ debg --- retry.try failed again with the same message...
[00:03:02]               └- ✖ fail: task_manager scheduling and running tasks should return a task run error result when trying to run a task now which is already running
[00:03:02]               │      retry.try timeout: Error: expected 'idle' to sort of equal 'running'
[00:03:02]               │     at Assertion.assert (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:100:11)
[00:03:02]               │     at Assertion.eql (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:244:8)
[00:03:02]               │     at retry.try (/dev/shm/workspace/parallel/13/kibana/x-pack/test/plugin_api_integration/test_suites/task_manager/task_manager_integration.js:131:54)
[00:03:02]               │   Error: retry.try timeout: Error: expected 'idle' to sort of equal 'running'
[00:03:02]               │       at Assertion.assert (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:100:11)
[00:03:02]               │       at Assertion.eql (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:244:8)
[00:03:02]               │       at retry.try (test/plugin_api_integration/test_suites/task_manager/task_manager_integration.js:131:54)
[00:03:02]               │       at onFailure (/dev/shm/workspace/parallel/13/kibana/test/common/services/retry/retry_for_success.ts:28:9)
[00:03:02]               │       at retryForSuccess (/dev/shm/workspace/parallel/13/kibana/test/common/services/retry/retry_for_success.ts:68:13)
[00:03:02]               │ 
[00:03:02]               │ 

Stack Trace

Error: retry.try timeout: Error: expected 'idle' to sort of equal 'running'
    at Assertion.assert (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:244:8)
    at retry.try (test/plugin_api_integration/test_suites/task_manager/task_manager_integration.js:131:54)
    at onFailure (/dev/shm/workspace/parallel/13/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/parallel/13/kibana/test/common/services/retry/retry_for_success.ts:68:13)

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +20.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 4ae6746 into elastic:master Aug 5, 2020
@kevinlog kevinlog deleted the bug/fix-flyout-hidden-by-nav branch August 5, 2020 22:32
kevinlog added a commit to kevinlog/kibana that referenced this pull request Aug 5, 2020
kevinlog added a commit to kevinlog/kibana that referenced this pull request Aug 5, 2020
kevinlog added a commit that referenced this pull request Aug 6, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kevinlog added a commit that referenced this pull request Aug 6, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 6, 2020
* master: (208 commits)
  Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465)
  [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010)
  Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073)
  Filter out non-security jobs when collecting Detections telemetry (elastic#74456)
  [Security Solution][Test] Enzyme test for related events button (elastic#74411)
  [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427)
  Rename package configs SO to package policies (elastic#74422)
  [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762)
  skip flaky suite (elastic#71390)
  [ML] DF Analytics: adds functional tests for edit form (elastic#73885)
  Rename agent configs SO to agent policies (elastic#74397)
  [Jenkins] run CI when plugin readmes change (elastic#74388)
  [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311)
  fixing encoding issue with \ for enroll command (elastic#74379)
  [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341)
  Change experimental message for visualizations (elastic#74354)
  [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715)
  [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323)
  update empty prompt in analytics list (elastic#74174)
  [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants