Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump babel deps to support TS v4 #74495

Merged
merged 1 commit into from
Aug 6, 2020
Merged

bump babel deps to support TS v4 #74495

merged 1 commit into from
Aug 6, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Aug 6, 2020

Summary

Babel v7.11 supports new syntax introduced in TSv4
Part of #71932

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Aug 6, 2020
@mshustov mshustov requested review from a team as code owners August 6, 2020 10:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@joshdover joshdover mentioned this pull request Aug 6, 2020
Closed
3 tasks
@mshustov mshustov mentioned this pull request Aug 6, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
console 1.1MB +12.0B 1.1MB
indexManagement 1.5MB +64.0B 1.5MB
ml 7.9MB -56.0B 7.9MB
securitySolution 7.3MB +94.0B 7.3MB
total +114.0B

page load bundle size

id value diff baseline
advancedSettings 980.7KB -6.0B 980.7KB
inputControlVis 295.7KB +64.0B 295.6KB
total +58.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo
Copy link
Member

afharo commented Aug 6, 2020

I noticed there are changes in packages/kbn-i18n/package.json. Shouldn't @elastic/kibana-localization be pinged as a codeowner (it looks like a CODEOWNERS file issue unrelated to this PR)?

@mshustov mshustov requested a review from a team August 6, 2020 12:09
afharo
afharo approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM!
File: packages/kbn-analytics/package.json

Tested and the UI analytics works great

spalger
spalger approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshustov mshustov merged commit 47fdd59 into elastic:master Aug 6, 2020
@mshustov mshustov deleted the bump-babel-deps branch August 6, 2020 20:00
@mshustov mshustov mentioned this pull request Aug 6, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Aug 6, 2020
@mshustov
bump babel deps to support TS v4 (elastic#74495)
625631e 
# Conflicts:
#	yarn.lock
mshustov added a commit that referenced this pull request Aug 7, 2020
@mshustov
[7.x] bump babel deps to support TS v4 (#74495) (#74591)
d5220d1 
* bump babel deps to support TS v4 (#74495)

# Conflicts:
#	yarn.lock

* update yarn lock
@spalger spalger mentioned this pull request Aug 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@afharo afharo afharo approved these changes

@joshdover joshdover joshdover approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mshustov @elasticmachine @kibanamachine @afharo @spalger @joshdover @streamich