[Security Solution][Exceptions] - Updates autocomplete validation for numbers and boolean #74561

yctercero · 2020-08-06T16:28:13Z

Summary

This PR chips ⛏️ a bit at some stricter value validations that have been discussed. Further validation is needed, but this adds some more basic validation.

Current: if selected field is of type boolean users can add custom values in combo box
- Now: if selected field is of type boolean users can only select true or false
Current: if selected field is of type number (that is kibana type number) user can input any values
- Now: if selected field is of type number and no autocomplete suggestions are available, number input is used to restrict users
Current: for operator match_any it's conducting an autocomplete search after each selection resulting in some jumpy/weird behavior
- Now: only conducts autocomplete search on initial field selection and if user enters value to search
Current: only validations on type date
- Now: validation on type (Kibana type) date, number
Current: input would show red when there was an error but user could still submit
- Now: submit button is disabled if error exists

TODO

can continue improving validation, this was just adding some basics

Boolean

Number w/ autocomplete values available

Number w/o autocomplete values available

Match any jitter

Before

After

Validation (disabling submit)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

…alue_validation

elasticmachine · 2020-08-11T20:24:48Z

Pinging @elastic/siem (Team:SIEM)

yctercero · 2020-08-13T16:49:54Z

@elasticmachine merge upstream

spong · 2020-08-14T22:26:28Z

Looks like when inputting an invalid value after a valid value has been selected the valid value persists and is what is submitted. Perhaps this invalid input should clear the field's value?

Empty -> Valid -> Invalid

Empty -> Invalid

spong · 2020-08-14T22:43:59Z

Just a bounds nit (so no need to fix here), but seems the field is truncated and displayed in scientific notation and the number picker no longer functions. This doesn't appear to cause any issues though, as modifying & re-saving the exception keeps the original value.

Also note, number validation doesn't take effect for is one of or is not one of operators. I don't think we can get the number picker to work with the multi-select, but looks like we can at least limit to numbers as per the ComboBox EUI docs (Custom options only, with validation).

x-pack/plugins/security_solution/public/common/components/autocomplete/field_value_match.tsx

...ck/plugins/security_solution/public/common/components/autocomplete/field_value_match_any.tsx

...ty_solution/public/common/components/autocomplete/hooks/use_field_value_autocomplete.test.ts

spong

Checked out locally and desk tested, and performed code review. Great cleanup here @yctercero, and even more tests to boot! 🎉 Left a couple nits and notes about some behaviors I was seeing (address if you'd like), but this LJLTM (Looks Just Lovely To Me :)! 👍

…alue_validation

yctercero · 2020-08-19T18:44:08Z

@spong Thanks so much for the 👀 . I went back and fixed the various things you noted. I made the input for boolean types into a select so now user can't even type anything in there. I also added validation for numbers when operator is one of. Lastly, updated to show errors below inputs and disable submit button if any errors exist. Let me know what you think!

x-pack/plugins/security_solution/public/common/components/autocomplete/field_value_match.tsx

...ck/plugins/security_solution/public/common/components/autocomplete/field_value_match_any.tsx

spong · 2020-08-19T21:01:13Z

Seeing an issue where switching fields (string->boolean) when validation is failed results in newly selected values from validatin:

spong · 2020-08-19T23:11:36Z

We're in super-nit territory at this point so feel free to ignore.... 😅

When changing focus the validation error will bounce between empty and type errors. I suppose my expectation would be for it stay not a valid number, but understand that the value isn't set (to fix that other issue above :), so definitely not a big deal. There's always UI/UX cornercases floating around validation, but you've covered all the main cases and gotchas, so we're already in a really good spot with all the improvements you've made in this PR -- many thanks @yctercero!! 🙂

I could see this going either way, but when a validation error is displayed it increases the height of the exception entry and will move the trash icon down to keep it vertically centered. May want to keep vertically centered with the value input field
(unless this is necessary to support smaller viewports).

…alue_validation

…ignalindex value

dplumlee · 2020-10-07T01:48:09Z

...plugins/security_solution/public/common/components/exceptions/edit_exception_modal/index.tsx

@@ -110,8 +110,11 @@ export const EditExceptionModal = memo(function EditExceptionModal({
  >([]);
  const { addError, addSuccess } = useAppToasts();
  const { loading: isSignalIndexLoading, signalIndexName } = useSignalIndex();
+  const memoSignalIndexName = useMemo(() => (signalIndexName !== null ? [signalIndexName] : []), [


this is working for me, good find 👍

kibanamachine · 2020-10-07T02:25:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a413d9a

Metrics [docs]

async chunks size

id	before	after	diff
`securitySolution`	10.5MB	10.5MB	+20.4KB

History

💔 Build #80354 failed 52d4279
💔 Build #69177 failed d31743f
💚 Build #67974 succeeded a4426472f937bc2602c43a32301fbfd61613bc93
💚 Build #67573 succeeded 8798b4d
💔 Build #67522 failed c832711

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… numbers and boolean (elastic#74561) ## Summary This PR chips a bit at some stricter value validations that have been discussed. Further validation is needed, but this adds some more basic validation. - **Current:** if selected field is of type `boolean` users can add custom values in combo box - **Now:** if selected field is of type `boolean` users can only select `true` or `false` - **Current:** if selected field is of type `number` (that is kibana type number) user can input any values - **Now:** if selected field is of type `number` and no autocomplete suggestions are available, number input is used to restrict users - **Current:** for operator `match_any` it's conducting an autocomplete search after each selection resulting in some jumpy/weird behavior - **Now:** only conducts autocomplete search on initial field selection and if user enters value to search - **Current:** only validations on type date - **Now:** validation on type (Kibana type) date, number - **Current:** input would show red when there was an error but user could still submit - **Now:** submit button is disabled if error exists

… numbers and boolean (#74561) (#79808) ## Summary This PR chips a bit at some stricter value validations that have been discussed. Further validation is needed, but this adds some more basic validation. - **Current:** if selected field is of type `boolean` users can add custom values in combo box - **Now:** if selected field is of type `boolean` users can only select `true` or `false` - **Current:** if selected field is of type `number` (that is kibana type number) user can input any values - **Now:** if selected field is of type `number` and no autocomplete suggestions are available, number input is used to restrict users - **Current:** for operator `match_any` it's conducting an autocomplete search after each selection resulting in some jumpy/weird behavior - **Now:** only conducts autocomplete search on initial field selection and if user enters value to search - **Current:** only validations on type date - **Now:** validation on type (Kibana type) date, number - **Current:** input would show red when there was an error but user could still submit - **Now:** submit button is disabled if error exists

elasticmachine · 2021-09-23T14:27:41Z

Pinging @elastic/security-solution (Team: SecuritySolution)

yctercero added 6 commits August 6, 2020 11:53

wip - trying to add a bit more validation to builder

4133023

Merge branch 'master' of github.com:yctercero/kibana into exception_v…

7c69d97

…alue_validation

fix field value match and match any component tests

0d54121

update unit tests

c832711

Merge branch 'master' of github.com:yctercero/kibana into exception_v…

8b11dd1

…alue_validation

update unit tests and types

8798b4d

yctercero marked this pull request as ready for review August 11, 2020 20:24

yctercero requested review from a team as code owners August 11, 2020 20:24

yctercero self-assigned this Aug 11, 2020

yctercero added Feature:Detection Rules Security Solution rules and Detection Engine release_note:enhancement release_note:fix Team:SIEM labels Aug 11, 2020

yctercero added v7.10.0 v8.0.0 labels Aug 11, 2020

spong reviewed Aug 14, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/autocomplete/field_value_match.tsx Outdated Show resolved Hide resolved

spong reviewed Aug 14, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/autocomplete/field_value_match.tsx Outdated Show resolved Hide resolved

spong reviewed Aug 14, 2020

View reviewed changes

...ck/plugins/security_solution/public/common/components/autocomplete/field_value_match_any.tsx Outdated Show resolved Hide resolved

spong reviewed Aug 14, 2020

View reviewed changes

...ty_solution/public/common/components/autocomplete/hooks/use_field_value_autocomplete.test.ts Show resolved Hide resolved

spong approved these changes Aug 14, 2020

View reviewed changes

yctercero added 5 commits August 17, 2020 10:57

Merge branch 'master' of github.com:yctercero/kibana into exception_v…

53029cd

…alue_validation

updated per feedback

3ce5fd6

Merge branch 'master' of github.com:yctercero/kibana into exception_v…

2d3d22f

…alue_validation

fix test types

f9917fd

updated test

d31743f

yctercero force-pushed the exception_value_validation branch from a442647 to d31743f Compare August 19, 2020 18:29

spong reviewed Aug 19, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/autocomplete/field_value_match.tsx Outdated Show resolved Hide resolved

spong reviewed Aug 19, 2020

View reviewed changes

...ck/plugins/security_solution/public/common/components/autocomplete/field_value_match_any.tsx Outdated Show resolved Hide resolved

yctercero added 5 commits September 2, 2020 09:57

Merge branch 'master' of github.com:yctercero/kibana into exception_v…

eea4b62

…alue_validation

Merge branch 'master' of github.com:yctercero/kibana into exception_v…

52d4279

…alue_validation

fixed bug

dad661a

remove unnecessary type

a7e8c1c

fixed bug found on master where edit modal hangs, needed to memoize s…

a413d9a

…ignalindex value

yctercero removed the release_note:enhancement label Oct 7, 2020

dplumlee reviewed Oct 7, 2020

View reviewed changes

yctercero merged commit 30695fb into elastic:master Oct 7, 2020

yctercero mentioned this pull request Oct 7, 2020

[7.x] [Security Solution][Exceptions] - Updates autocomplete validation for numbers and boolean (#74561) #79808

Merged

yctercero deleted the exception_value_validation branch October 14, 2020 11:59

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Exceptions] - Updates autocomplete validation for numbers and boolean #74561

[Security Solution][Exceptions] - Updates autocomplete validation for numbers and boolean #74561

yctercero commented Aug 6, 2020 •

edited

Loading

elasticmachine commented Aug 11, 2020

yctercero commented Aug 13, 2020

spong commented Aug 14, 2020

spong commented Aug 14, 2020

spong left a comment

yctercero commented Aug 19, 2020

spong commented Aug 19, 2020

spong commented Aug 19, 2020

dplumlee Oct 7, 2020

kibanamachine commented Oct 7, 2020

elasticmachine commented Sep 23, 2021

[Security Solution][Exceptions] - Updates autocomplete validation for numbers and boolean #74561

[Security Solution][Exceptions] - Updates autocomplete validation for numbers and boolean #74561

Conversation

yctercero commented Aug 6, 2020 • edited Loading

Summary

TODO

Boolean

Number w/ autocomplete values available

Number w/o autocomplete values available

Match any jitter

Before

After

Validation (disabling submit)

Checklist

elasticmachine commented Aug 11, 2020

yctercero commented Aug 13, 2020

spong commented Aug 14, 2020

spong commented Aug 14, 2020

spong left a comment

Choose a reason for hiding this comment

yctercero commented Aug 19, 2020

spong commented Aug 19, 2020

spong commented Aug 19, 2020

dplumlee Oct 7, 2020

Choose a reason for hiding this comment

kibanamachine commented Oct 7, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

History

elasticmachine commented Sep 23, 2021

yctercero commented Aug 6, 2020 •

edited

Loading