[build] Include babelcache so it can be chowned to kibana user #7458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
| module.exports = function (grunt) { | |||
There was a problem hiding this comment.
export default here instead of commonjs.
|
jenkins, test it |
|
LGTM |
This was referenced Jun 15, 2016
elastic-jasper
added a commit
that referenced
this pull request
Jun 15, 2016
--------- **Commit 1:** [build] Include babelcache so it can be chowned to kibana user * Original sha: 83681d9 * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-06-14T21:48:41Z
elastic-jasper
added a commit
that referenced
this pull request
Jun 15, 2016
--------- **Commit 1:** [build] Include babelcache so it can be chowned to kibana user * Original sha: 83681d9 * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-06-14T21:48:41Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[build] Include babelcache so it can be chowned to kibana user Former-commit-id: e81e1f2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When optimization is ran as root (or another user) .babelcache.json is written with permissions that may not allow package installs to write to file. This includes an empty cache file in builds and package post install scripts will chown this to the kibana user.
This can be reproduce by installing a kibana package, and before starting the server installing a plugin.
Closes #6730