Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Use CentOS/UBI 8.2 as Docker base image #74656

Merged
merged 4 commits into from
Aug 17, 2020

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Aug 10, 2020

  • Move to CentOS 8 and UBI 8 base images
  • Cleanup Dockerfile by using template over string interpolation
  • Adds retry logic to yum commands
  • Adds org.opencontainers.* labels

Builds:

Testing:

  • Download one of the Docker images (kibana-8.0.0-SNAPSHOT-docker.tar.gz as an example)

  • Load the image:

    $ docker load -i kibana-8.0.0-SNAPSHOT-docker.tar.gz
    Loaded image: docker.elastic.co/kibana/kibana:8.0.0-SNAPSHOT
    
  • Run Kibana. Be sure to update the image name which was provided by the previous command. You will also need to have Elasticsearch running (example: yarn es snapshot from Kibana source root directory)

    docker run --rm --network host -e ELASTICSEARCH_HOSTS=http://127.0.0.1:9200 -e ELASTICSEARCH_USERNAME=elastic -e ELASTICSEARCH_PASSWORD=changeme docker.elastic.co/kibana/kibana:8.0.0-SNAPSHOT

Release note

Docker containers now use CentOS 8.2 as the base image, upgrading from 7.7.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley changed the title [build] Change UBI to ubi8/ubi-minimal [build] CentOS/UBI 8 as Docker base image Aug 12, 2020
@tylersmalley tylersmalley marked this pull request as ready for review August 12, 2020 17:05
@tylersmalley tylersmalley requested a review from a team as a code owner August 12, 2020 17:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley changed the title [build] CentOS/UBI 8 as Docker base image [build] CentOS/UBI 8.2 as Docker base image Aug 12, 2020
@tylersmalley tylersmalley changed the title [build] CentOS/UBI 8.2 as Docker base image [build] Use CentOS/UBI 8.2 as Docker base image Aug 12, 2020
@mieciu
Copy link
Contributor

mieciu commented Aug 13, 2020

I'm going to keep an eye on it as it's going to affect Cloud 😉

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

Here is the Elasticsearch UBI PR for comparison: elastic/elasticsearch#60742

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor Author

@jbudz want to give this another pass?

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley requested a review from a team August 17, 2020 17:19
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the images - the only note I have is do you think we should address

"Chromium sandbox provides an additional layer of protection, but is not supported for Linux Red Hat Linux 8.2 OS. Automatically setting 'xpack.reporting.capture.browser.chromium.disableSandbox: true'."}

@tylersmalley
Copy link
Contributor Author

@jbudz, I believe that is OK since the container is running in a namespace already. @elastic/kibana-reporting-services can you confirm?

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving pending any concerns from the reporting team - I've reviewed the code and tested the images otherwise.

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I built it off this PR and ran the Kibana UBI image against Elasticsearch latest snapshot.

@tylersmalley
Copy link
Contributor Author

Pinged reporting team and this notice is expected and isn't an issue since Docker is already namespaced negating sandboxing.

@tylersmalley tylersmalley merged commit 83678e1 into elastic:master Aug 17, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Aug 17, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Aug 17, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
axw added a commit to axw/beats that referenced this pull request Aug 19, 2020
With elastic/kibana#74656,
Kibana images will no longer have Python installed.
Instead of parsing the result, just look for the
string "Looking good", which indicates Kibana is
healthy.
axw added a commit to elastic/beats that referenced this pull request Aug 19, 2020
* testing: fix Kibana healthcheck

With elastic/kibana#74656,
Kibana images will no longer have Python installed.
Instead of parsing the result, just look for the
string "Looking good", which indicates Kibana is
healthy.
axw added a commit to axw/beats that referenced this pull request Aug 19, 2020
* testing: fix Kibana healthcheck

With elastic/kibana#74656,
Kibana images will no longer have Python installed.
Instead of parsing the result, just look for the
string "Looking good", which indicates Kibana is
healthy.

(cherry picked from commit 73f8bea)
axw added a commit to elastic/beats that referenced this pull request Aug 19, 2020
* testing: fix Kibana healthcheck

With elastic/kibana#74656,
Kibana images will no longer have Python installed.
Instead of parsing the result, just look for the
string "Looking good", which indicates Kibana is
healthy.

(cherry picked from commit 73f8bea)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
* testing: fix Kibana healthcheck

With elastic/kibana#74656,
Kibana images will no longer have Python installed.
Instead of parsing the result, just look for the
string "Looking good", which indicates Kibana is
healthy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants