-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Use CentOS/UBI 8.2 as Docker base image #74656
Conversation
f68e47b
to
6afee20
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
6afee20
to
0d587ba
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
I'm going to keep an eye on it as it's going to affect Cloud 😉 |
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Here is the Elasticsearch UBI PR for comparison: elastic/elasticsearch#60742 |
@elasticmachine merge upstream |
@jbudz want to give this another pass? |
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the images - the only note I have is do you think we should address
"Chromium sandbox provides an additional layer of protection, but is not supported for Linux Red Hat Linux 8.2 OS. Automatically setting 'xpack.reporting.capture.browser.chromium.disableSandbox: true'."}
@jbudz, I believe that is OK since the container is running in a namespace already. @elastic/kibana-reporting-services can you confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving pending any concerns from the reporting team - I've reviewed the code and tested the images otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I built it off this PR and ran the Kibana UBI image against Elasticsearch latest snapshot.
Pinged reporting team and this notice is expected and isn't an issue since Docker is already namespaced negating sandboxing. |
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
With elastic/kibana#74656, Kibana images will no longer have Python installed. Instead of parsing the result, just look for the string "Looking good", which indicates Kibana is healthy.
* testing: fix Kibana healthcheck With elastic/kibana#74656, Kibana images will no longer have Python installed. Instead of parsing the result, just look for the string "Looking good", which indicates Kibana is healthy.
* testing: fix Kibana healthcheck With elastic/kibana#74656, Kibana images will no longer have Python installed. Instead of parsing the result, just look for the string "Looking good", which indicates Kibana is healthy. (cherry picked from commit 73f8bea)
* testing: fix Kibana healthcheck With elastic/kibana#74656, Kibana images will no longer have Python installed. Instead of parsing the result, just look for the string "Looking good", which indicates Kibana is healthy. (cherry picked from commit 73f8bea)
* testing: fix Kibana healthcheck With elastic/kibana#74656, Kibana images will no longer have Python installed. Instead of parsing the result, just look for the string "Looking good", which indicates Kibana is healthy.
org.opencontainers.*
labelsBuilds:
Testing:
Download one of the Docker images (
kibana-8.0.0-SNAPSHOT-docker.tar.gz
as an example)Load the image:
Run Kibana. Be sure to update the image name which was provided by the previous command. You will also need to have Elasticsearch running (example:
yarn es snapshot
from Kibana source root directory)docker run --rm --network host -e ELASTICSEARCH_HOSTS=http://127.0.0.1:9200 -e ELASTICSEARCH_USERNAME=elastic -e ELASTICSEARCH_PASSWORD=changeme docker.elastic.co/kibana/kibana:8.0.0-SNAPSHOT
Release note
Docker containers now use CentOS 8.2 as the base image, upgrading from 7.7.