Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Enterprise Search] Update the browser/document title on plugin navigation (#74392) #74694

Merged
merged 1 commit into from
Aug 10, 2020

Commits on Aug 10, 2020

  1. [Enterprise Search] Update the browser/document title on plugin navig…

    …ation (elastic#74392)
    
    * Rename kibana_breadcrumbs to kibana_chrome
    
    - in anticipation of upcoming refactor where SetPageChrome now handles document title as well as Kibana breadcrumbs
    + cleanup exports
    
    * Add generate_title helpers
    
    - will be used by new set_chrome helper
    
    * Add setDocTitle context + behavior to set_chrome
    
    + refactor set_chrome.test.tsx:
      - add title tests
      - add SetWorkplaceSearchChrome test to increase coverage
      - clean up inner/outer call in favor of simpler mocks/imports
      - simplify isRoot tests
    
    * Update plugins to set product titles
    - on mount but before render
    
    * Copy feedback - change pipe separator to hyphen
    
    - to match ' - Elastic'
    
    * Add functional tests confirming that document titles updated
    Constance authored and cee-chen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    e77458d View commit details
    Browse the repository at this point in the history