Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Index pattern field list - transition away from extending array - introduce and use getAll() (#74718) #74756

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

mattkime
Copy link
Contributor

Backports the following commits to 7.x:

…roduce and use getAll() (elastic#74718)

- Introduce `indexPattern.fields.getAll()` and use where possible
- Rename `index_patterns/fields/fields.mocks.ts.ts => index_patterns/fields/fields.mocks.ts`
- FieldSpec - make `count` and `scripted` fields optional
- use `indexPattern.fields.getByName` instead of filter where possible
# Conflicts:
#	src/plugins/index_pattern_management/public/components/field_editor/field_editor.test.tsx
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
discover 431.6KB +26.0B 431.6KB
indexPatternManagement 698.1KB +23.0B 698.1KB
total +49.0B

page load bundle size

id value diff baseline
data 1.4MB +141.0B 1.4MB
discover 229.0KB -87.0B 229.0KB
inputControlVis 295.7KB +9.0B 295.7KB
visTypeTimelion 711.9KB +27.0B 711.8KB
total +90.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit f4b44c7 into elastic:7.x Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants