[ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components #74886

efreeti · 2020-08-12T17:43:18Z

Summary

Reintroduced tabs to endpoint management section of security and migrated the views to shared security components.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…mmon security components.

elasticmachine · 2020-08-12T17:45:28Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-08-12T17:45:28Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

x-pack/plugins/security_solution/public/management/components/management_tabs.ts

paul-tavares

Some feedback included. I'm also going to try and check this out today and run it locally - will post back if I notice anything.

Have you had a quick Demo with @bfishel on this? Only because it maybe changing the design from what she had originally envisioned so just want to ensure she's aware.

One last thing: can you include some screen capture (or video/GIF) to the PR description?

x-pack/plugins/security_solution/public/management/components/management_tabs.ts

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx

x-pack/plugins/security_solution/public/common/components/wrapper_page/index.tsx

paul-tavares · 2020-08-13T12:52:10Z

Ran it locally and it looks good. Disregard my comment around tab clicking and full page refresh - it seems to work as expected.

x-pack/plugins/security_solution/public/management/components/management_tabs.ts

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx

x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx

kevinlog · 2020-08-13T22:53:44Z

pulled it down and it looks good to me, just fix the tests and consider @paul-tavares suggestion on wrapping the <WrapperComponent>

EDIT: Also, put a screenshot up!

…bala/trusted-apps-page

paul-tavares

LGTM

Had some question and minor feedback which can be address later

x-pack/plugins/security_solution/public/management/common/routing.ts

x-pack/plugins/security_solution/public/management/components/administration_list_page.tsx

x-pack/plugins/security_solution/public/management/pages/index.test.tsx

x-pack/plugins/security_solution/public/management/pages/index.tsx

x-pack/plugins/security_solution/public/common/components/wrapper_page/index.tsx

XavierM

I think we should put back the const and avoid merging the code with function. So we do not start introducing back the function style in the repo

efreeti · 2020-08-18T10:57:15Z

@XavierM What is the reason to discourage function declarations? I find even readability of the code worse when using const and lambda.

paul-tavares

Agree with @kevinlog that we should get this in. My comments were minor and optional. I left some more in response to your last set of comments.

👍

x-pack/plugins/security_solution/public/management/common/routing.ts

x-pack/plugins/security_solution/public/management/components/administration_list_page.tsx

kevinlog

I would ask that we change the function expressions back to lamda's before merging.

XavierM · 2020-08-18T13:37:24Z

@XavierM What is the reason to discourage function declarations? I find even readability of the code worse when using const and lambda.

I think because we want to follow that https://github.com/elastic/kibana/blob/master/STYLEGUIDE.md#prefer-modern-javascripttypescript-syntax

efreeti · 2020-08-18T13:59:57Z

https://github.com/elastic/kibana/blob/master/STYLEGUIDE.md#prefer-modern-javascripttypescript-syntax

@XavierM What is the reason to discourage function declarations? I find even readability of the code worse when using const and lambda.

I think because we want to follow that https://github.com/elastic/kibana/blob/master/STYLEGUIDE.md#prefer-modern-javascripttypescript-syntax

As mentioned it says Prefer arrow function over function expressions not over function declarations. But sure I'll revert it back.

efreeti · 2020-08-18T15:44:31Z

fixed function declarations, and added memo.

kevinlog · 2020-08-18T16:07:55Z

Thanks for the changes!

kibanamachine · 2020-08-18T17:27:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 508edb5

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	1916	+2	1914

async chunks size

id	value	diff	baseline
securitySolution	7.2MB	-3.5KB	7.2MB

page load bundle size

id	value	diff	baseline
securitySolution	806.8KB	+763.0B	806.1KB

History

💚 Build #68544 succeeded 5831069
💔 Build #68486 failed d14ea15
💔 Build #68413 failed 9160aa0
💔 Build #68398 failed f1a2a3a
💔 Build #67945 failed bfc62d5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…s to use common security components (elastic#74886) * Reintroduced tabs to endpoint management and migrated pages to use common security components. * Empty trusted apps tab. * Changed casing in the translations. * Switched to using route path generation functions. * Added propagation of data-test-subj attribute to Wrapper component. * Fixed CommonProps import. * Moved out shared component for administration list page. * Removed unused file. * Removed unused translation keys. * Removed redundant snapshot. * Added some minimal tests. * Attempt to fix functional tests. * Attempt to fix functional tests again. * Reverted function declarations back to const. * Wrapped component in memo.

…s to use common security components (#74886) (#75352) * Reintroduced tabs to endpoint management and migrated pages to use common security components. * Empty trusted apps tab. * Changed casing in the translations. * Switched to using route path generation functions. * Added propagation of data-test-subj attribute to Wrapper component. * Fixed CommonProps import. * Moved out shared component for administration list page. * Removed unused file. * Removed unused translation keys. * Removed redundant snapshot. * Added some minimal tests. * Attempt to fix functional tests. * Attempt to fix functional tests again. * Reverted function declarations back to const. * Wrapped component in memo.

* master: (112 commits) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) Fix docs in trigger alerting UI (elastic#75363) [SIEM] Fixes search bar Cypress test (elastic#74833) Add libnss3.so to Dockerfile template (reporting) (elastic#75370) [Discover] Create field_button and add popovers to sidebar (elastic#73226) [Reporting] Network Policy: Do not throw from the intercept handler (elastic#75105) [Reporting] Increase capture.timeouts.openUrl to 1 minute (elastic#75207) Allow routes to specify the idle socket timeout in addition to the payload timeout (elastic#73730) [src/dev/build] remove node-version from snapshots (elastic#75303) [ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components (elastic#74886) [Canvas] Remove dependency on legacy expressions APIs (elastic#74885) Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) ...

Reintroduced tabs to endpoint management and migrated pages to use co…

5af098c

…mmon security components.

efreeti requested review from a team as code owners August 12, 2020 17:43

efreeti self-assigned this Aug 12, 2020

efreeti added Feature:Endpoint Elastic Endpoint feature Team:Endpoint Management v7.10.0 v8.0.0 labels Aug 12, 2020

efreeti added the release_note:skip Skip the PR/issue when compiling release notes label Aug 12, 2020

pzl reviewed Aug 12, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/components/management_tabs.ts Outdated Show resolved Hide resolved

paul-tavares reviewed Aug 12, 2020

View reviewed changes

efreeti added 2 commits August 13, 2020 17:13

Empty trusted apps tab.

820f294

Changed casing in the translations.

bfc62d5

pzl reviewed Aug 13, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/components/management_tabs.ts Outdated Show resolved Hide resolved

kevinlog reviewed Aug 13, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx Outdated Show resolved Hide resolved

kevinlog reviewed Aug 13, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx Show resolved Hide resolved

efreeti added 10 commits August 17, 2020 11:57

Switched to using route path generation functions.

9ce1421

Added propagation of data-test-subj attribute to Wrapper component.

d4ca664

Fixed CommonProps import.

e5f9aed

Moved out shared component for administration list page.

05b9160

Merge branch 'master' of https://github.com/elastic/kibana into btsym…

17f5389

…bala/trusted-apps-page

Removed unused file.

f1a2a3a

Removed unused translation keys.

a637c56

Removed redundant snapshot.

9160aa0

Added some minimal tests.

fe26693

Attempt to fix functional tests.

d14ea15

Attempt to fix functional tests again.

5831069

paul-tavares approved these changes Aug 17, 2020

View reviewed changes

XavierM reviewed Aug 17, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/wrapper_page/index.tsx Show resolved Hide resolved

XavierM reviewed Aug 17, 2020

View reviewed changes

paul-tavares approved these changes Aug 18, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/common/routing.ts Outdated Show resolved Hide resolved

x-pack/plugins/security_solution/public/management/components/administration_list_page.tsx Outdated Show resolved Hide resolved

kevinlog suggested changes Aug 18, 2020

View reviewed changes

efreeti added 2 commits August 18, 2020 17:11

Reverted function declarations back to const.

de4a33f

Wrapped component in memo.

508edb5

kevinlog approved these changes Aug 18, 2020

View reviewed changes

efreeti merged commit 4a274e0 into elastic:master Aug 18, 2020

efreeti deleted the btsymbala/trusted-apps-page branch August 18, 2020 17:42

efreeti mentioned this pull request Aug 18, 2020

[7.x] [ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components (#74886) #75352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components #74886

[ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components #74886

efreeti commented Aug 12, 2020 •

edited

Loading

elasticmachine commented Aug 12, 2020

elasticmachine commented Aug 12, 2020

paul-tavares left a comment

paul-tavares commented Aug 13, 2020

kevinlog commented Aug 13, 2020 •

edited

Loading

paul-tavares left a comment

XavierM left a comment

efreeti commented Aug 18, 2020

paul-tavares left a comment

kevinlog left a comment

XavierM commented Aug 18, 2020

efreeti commented Aug 18, 2020

efreeti commented Aug 18, 2020

kevinlog commented Aug 18, 2020

kibanamachine commented Aug 18, 2020

[ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components #74886

[ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components #74886

Conversation

efreeti commented Aug 12, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Aug 12, 2020

elasticmachine commented Aug 12, 2020

paul-tavares left a comment

Choose a reason for hiding this comment

paul-tavares commented Aug 13, 2020

kevinlog commented Aug 13, 2020 • edited Loading

paul-tavares left a comment

Choose a reason for hiding this comment

XavierM left a comment

Choose a reason for hiding this comment

efreeti commented Aug 18, 2020

paul-tavares left a comment

Choose a reason for hiding this comment

kevinlog left a comment

Choose a reason for hiding this comment

XavierM commented Aug 18, 2020

efreeti commented Aug 18, 2020

efreeti commented Aug 18, 2020

kevinlog commented Aug 18, 2020

kibanamachine commented Aug 18, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

efreeti commented Aug 12, 2020 •

edited

Loading

kevinlog commented Aug 13, 2020 •

edited

Loading