Consistent build archives #7495

epixa · 2016-06-17T14:01:58Z

We do not release zip archives for any operating system except windows,
and we do not release tar.gz archives for windows. The build task will no
longer create those erroneous artifacts.

For consistency and clarity sake, we'll explicitly list the architecture (x86)
of the windows build as well.

The relevant build changes are in the first commit: 2f2742e
The second commit is just a code cleanup: c00e49d

Closes #7483

epixa · 2016-06-17T14:02:59Z

/cc @rjernst

epixa · 2016-06-17T14:04:48Z

The build tasks really need a complete overhaul at this point as they were originally architected with an inherent 1:1 relationship between node.js binaries and Kibana builds, which at this point is only true of darwin.

But we can take care of that later without blocking the unified release process.

jbudz · 2016-06-17T14:27:29Z

jenkins, test it

jbudz · 2016-06-17T14:29:38Z

Can we update the windows snapshot urls too?

jbudz · 2016-06-17T14:34:23Z

tasks/release.js

@@ -51,6 +51,15 @@ module.exports = function (grunt) {
        platform.debName && platform.debName + '.sha1.txt'
      );
    }, [])
+    .reduce((files, file) => {


I believe we'll get this for free if we add windows-x64 and windows-x86 to https://github.com/epixa/kibana/blob/7ac1efe859d865e4159fd42705e8856f4035470b/tasks/config/platforms.js#L13

I don't want two separate builds being created, though. I want windows to be treated as a single build that simple gets renamed/zipped at the end, otherwise we'll need to smoketest/QA multiple windows builds.

jbudz · 2016-06-17T14:39:08Z

Should we make https://nodejs.org/dist/v4.4.4/win-x64 part of the url in https://github.com/epixa/kibana/blob/7ac1efe859d865e4159fd42705e8856f4035470b/tasks/config/platforms.js#L17?

epixa · 2016-06-17T14:40:19Z

Damn snapshots!

epixa · 2016-06-17T14:41:17Z

@jbudz To be clear: I do not want to create separate windows builds. We provide a 32 bit build, and that build should work on 64 bit as well.

epixa · 2016-06-17T14:48:06Z

Updated the readme link to point to the x86 version.

jbudz · 2016-06-17T14:52:31Z

LGTM

epixa · 2016-06-17T18:34:47Z

I'm undecided on this approach, so I'm going to hold off merging for now.

We do not release zip archives for any operating system except windows, and we do not release tar.gz archives for windows. For consistency and clarity sake, we'll explicitly list the architecture (x86) of the windows build as well.

This just a code cleanup - there are no functional changes to this task.

epixa · 2016-07-06T01:39:14Z

Alright @jbudz, this is good for review.

jbudz · 2016-07-06T14:39:01Z

Should https://github.com/epixa/kibana/blob/c00e49dd062bc89796c241a56151d65e3f97b18b/tasks/rebuild/create_archives.js#L16 be updated too?

epixa · 2016-07-06T22:31:53Z

Nah, I'm going to delete all of the rebuilding stuff.

jbudz · 2016-07-06T22:37:31Z

LGTM

--------- **Commit 1:** Consistent build archives We do not release zip archives for any operating system except windows, and we do not release tar.gz archives for windows. For consistency and clarity sake, we'll explicitly list the architecture (x86) of the windows build as well. * Original sha: 2f2742e * Authored by Court Ewing <court@epixa.com> on 2016-06-17T13:20:44Z **Commit 2:** internal: Cleanup code in _build:archives task This just a code cleanup - there are no functional changes to this task. * Original sha: c00e49d * Authored by Court Ewing <court@epixa.com> on 2016-06-17T13:39:14Z

[backport] PR #7495 to 4.x

--------- **Commit 1:** Consistent build archives We do not release zip archives for any operating system except windows, and we do not release tar.gz archives for windows. For consistency and clarity sake, we'll explicitly list the architecture (x86) of the windows build as well. * Original sha: 2f2742e * Authored by Court Ewing <court@epixa.com> on 2016-06-17T13:20:44Z **Commit 2:** internal: Cleanup code in _build:archives task This just a code cleanup - there are no functional changes to this task. * Original sha: c00e49d * Authored by Court Ewing <court@epixa.com> on 2016-06-17T13:39:14Z

Consistent build archives Former-commit-id: ac40188

`v92.2.1` ⏩ `v93.0.0` --- ## [`v93.0.0`](https://github.com/elastic/eui/releases/v93.0.0) **Bug fixes** - Fixed `EuiTextTruncate` component to clean up timer from side effect on unmount ([#7495](elastic/eui#7495)) **Breaking changes** - Removed deprecated `anchorClassName` prop from `EuiPopover`. Use `className` instead ([#7488](elastic/eui#7488)) - Removed deprecated `buttonRef` prop from `EuiPopover`. Use `popoverRef` instead ([#7488](elastic/eui#7488)) - Removed deprecated `toolTipTitle` and `toolTipPosition` props from `EuiContextMenuItem`. Use `toolTipProps.title` and `toolTipProps.position` instead ([#7489](elastic/eui#7489)) - Removed deprecated internal `setSelection` ref method from `EuiInMemoryTable` and `EuiBasicTable`. Use the new controlled `selection.selected` prop API instead. ([#7491](elastic/eui#7491)) - `EuiTourStep`'s `className` and `style` props now apply to the anchoring element instead of to the popover panel, to match `EuiPopover` behavior. ([#7497](elastic/eui#7497)) - Convert your existing usages to `panelClassName` and `panelStyle` respectively instead. **Performance** - Improved the amount of recomputed styles being generated by `EuiCode` and `EuiCodeBlock` ([#7486](elastic/eui#7486)) **CSS-in-JS conversions** - Converted `EuiSearchBar` to Emotion ([#7490](elastic/eui#7490)) - Converted `EuiEmptyPrompt` to Emotion ([#7494](elastic/eui#7494)) - Added `euiBorderColor` and `useEuiBorderColorCSS` style utilities ([#7494](elastic/eui#7494)) --------- Co-authored-by: Jon <jon@elastic.co>

`v92.2.1` ⏩ `v93.0.0` --- ## [`v93.0.0`](https://github.com/elastic/eui/releases/v93.0.0) **Bug fixes** - Fixed `EuiTextTruncate` component to clean up timer from side effect on unmount ([elastic#7495](elastic/eui#7495)) **Breaking changes** - Removed deprecated `anchorClassName` prop from `EuiPopover`. Use `className` instead ([elastic#7488](elastic/eui#7488)) - Removed deprecated `buttonRef` prop from `EuiPopover`. Use `popoverRef` instead ([elastic#7488](elastic/eui#7488)) - Removed deprecated `toolTipTitle` and `toolTipPosition` props from `EuiContextMenuItem`. Use `toolTipProps.title` and `toolTipProps.position` instead ([elastic#7489](elastic/eui#7489)) - Removed deprecated internal `setSelection` ref method from `EuiInMemoryTable` and `EuiBasicTable`. Use the new controlled `selection.selected` prop API instead. ([elastic#7491](elastic/eui#7491)) - `EuiTourStep`'s `className` and `style` props now apply to the anchoring element instead of to the popover panel, to match `EuiPopover` behavior. ([elastic#7497](elastic/eui#7497)) - Convert your existing usages to `panelClassName` and `panelStyle` respectively instead. **Performance** - Improved the amount of recomputed styles being generated by `EuiCode` and `EuiCodeBlock` ([elastic#7486](elastic/eui#7486)) **CSS-in-JS conversions** - Converted `EuiSearchBar` to Emotion ([elastic#7490](elastic/eui#7490)) - Converted `EuiEmptyPrompt` to Emotion ([elastic#7494](elastic/eui#7494)) - Added `euiBorderColor` and `useEuiBorderColorCSS` style utilities ([elastic#7494](elastic/eui#7494)) --------- Co-authored-by: Jon <jon@elastic.co>

epixa added blocker review v4.6.0 v5.0.0-beta1 labels Jun 17, 2016

epixa assigned jbudz Jun 17, 2016

epixa added v5.0.0-alpha4 blocker and removed blocker v5.0.0-beta1 labels Jun 17, 2016

jbudz reviewed Jun 17, 2016
View reviewed changes

epixa force-pushed the urp branch from 7ac1efe to ed8cf72 Compare June 17, 2016 14:47

epixa assigned epixa and unassigned jbudz Jun 17, 2016

epixa added blocked and removed blocker labels Jun 17, 2016

jbudz added v5.0.0-beta1 and removed v5.0.0-alpha4 labels Jun 21, 2016

epixa force-pushed the urp branch from ed8cf72 to 96a962c Compare July 4, 2016 15:44

epixa removed the review label Jul 4, 2016

epixa force-pushed the urp branch from 96a962c to fe346af Compare July 6, 2016 00:11

epixa force-pushed the urp branch from fe346af to f42c071 Compare July 6, 2016 01:16

epixa added review and removed blocked labels Jul 6, 2016

epixa added 2 commits July 5, 2016 21:19

Consistent build archives

2f2742e

We do not release zip archives for any operating system except windows, and we do not release tar.gz archives for windows. For consistency and clarity sake, we'll explicitly list the architecture (x86) of the windows build as well.

internal: Cleanup code in _build:archives task

c00e49d

This just a code cleanup - there are no functional changes to this task.

epixa force-pushed the urp branch from f42c071 to c00e49d Compare July 6, 2016 01:21

epixa assigned jbudz and unassigned epixa Jul 6, 2016

epixa merged commit ac40188 into elastic:master Jul 6, 2016

epixa deleted the urp branch July 6, 2016 22:39

epixa added v5.0.0-alpha5 and removed v5.0.0-beta1 labels Jul 20, 2016

elastic-jasper mentioned this pull request Jul 22, 2016

[backport] PR #7495 to 4.x - Consistent build archives #7813

Merged

epixa added a commit that referenced this pull request Jul 22, 2016

Merge pull request #7813 from elastic/jasper/backport/7495/4.x

fc40231

[backport] PR #7495 to 4.x

elastic-jasper mentioned this pull request Jul 22, 2016

[backport] PR #7495 to 4.x - Consistent build archives #7817

Closed

epixa added v5.0.0 and removed v5.0.0 labels Aug 1, 2016

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#7495 from epixa/urp

9e89f1a

Consistent build archives Former-commit-id: ac40188

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consistent build archives #7495

Consistent build archives #7495

epixa commented Jun 17, 2016 •

edited

Loading

epixa commented Jun 17, 2016

epixa commented Jun 17, 2016

jbudz commented Jun 17, 2016

jbudz commented Jun 17, 2016

jbudz Jun 17, 2016

epixa Jun 17, 2016

jbudz commented Jun 17, 2016

epixa commented Jun 17, 2016

epixa commented Jun 17, 2016

epixa commented Jun 17, 2016

jbudz commented Jun 17, 2016

epixa commented Jun 17, 2016

epixa commented Jul 6, 2016

jbudz commented Jul 6, 2016

epixa commented Jul 6, 2016

jbudz commented Jul 6, 2016

Consistent build archives #7495

Consistent build archives #7495

Conversation

epixa commented Jun 17, 2016 • edited Loading

epixa commented Jun 17, 2016

epixa commented Jun 17, 2016

jbudz commented Jun 17, 2016

jbudz commented Jun 17, 2016

jbudz Jun 17, 2016

Choose a reason for hiding this comment

epixa Jun 17, 2016

Choose a reason for hiding this comment

jbudz commented Jun 17, 2016

epixa commented Jun 17, 2016

epixa commented Jun 17, 2016

epixa commented Jun 17, 2016

jbudz commented Jun 17, 2016

epixa commented Jun 17, 2016

epixa commented Jul 6, 2016

jbudz commented Jul 6, 2016

epixa commented Jul 6, 2016

jbudz commented Jul 6, 2016

epixa commented Jun 17, 2016 •

edited

Loading