[ML] WIP - Extend MlUrlGenerator & convert ML urls to non-hash

[qn895]

Summary

Part of #69265

This DRAFT PR is a WIP attempt to consolidate the url generating service within the ML plugin.

Current it's contingent on this PR #74955 being merged in, but the original commit from that PR is being included here to prevent typescript from breaking.

It's not currently replacing everything yet, just snippets to see how it would work if replaced. For example, it can be used by other team's with Kibana's navigateToUrl

  const urlGenerator = useMlUrlGenerator();
  const {
    services: {
      application: { navigateToUrl },
    },
  } = useMlKibana();

  const redirectToAnalyticsManagementPage = async () => {
    const url = await urlGenerator.createUrl({ page: ML_TABS.DATA_FRAME_ANALYTICS });
    await navigateToUrl(url);
  };

or our own Ml's navigateToPath which can optionally preserve the search queries

  const urlGenerator = useMlUrlGenerator();
  const navigateToPath = useNavigateToPath();

  const redirectToAnalyticsManagementPage = async () => {
    const path = await urlGenerator.createUrl({
      page: 'data_frame_analytics/exploration',
      jobId,
      analysisType,
    });
    await navigateToPath(path, preserveSearch);
  };

[darnautov]

I don't think you should change the content of kibana_utils

[qn895]

That change is now merged in here #74955.

[darnautov]

Please remove destructuring from the function arguments, and change to something like

Suggested change

	if (page === ML_TABS.ANOMALY_DETECTION) {
	public readonly createUrl = async (mlUrlGeneratorState: MlUrlGeneratorState): Promise<string> => {
	switch(mlUrlGeneratorState) {
	case mlUrlGeneratorState.page === ML_TABS.ANOMALY_DETECTION:
	return this.createAnomalyDetectionJobManagementUrl(mlUrlGeneratorState)
	}

in that case, TS will take care of typecasting and there is no need to do it manually.

[qn895]

This is a good spot. And with this way it's much cleaner too! Thanks 🙏

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 98dd2e5
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Check Doc API Changes
• X-Pack Jest Unit Tests

---

Test Failures

X-Pack Jest Tests.x-pack/plugins/lens/public/app_plugin.Lens App sets originatingApp breadcrumb when the document title changes

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/75694

Stack Trace

Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

- Expected
+ Received

  Array [
    Object {
-     "onClick": Anything,
+     "onClick": [Function onClick],
      "text": "The Coolest Container Ever Made",
    },
    Object {
      "href": "/testbasepath/app/visualize#/",
-     "onClick": Anything,
+     "onClick": [Function onClick],
      "text": "Visualize",
    },
    Object {
-     "text": "Daaaaaaadaumching!",
+     "text": "Create",
    },
  ],

Number of calls: 1
    at Object.it (/dev/shm/workspace/parallel/10/kibana/x-pack/plugins/lens/public/app_plugin/app.test.tsx:328:52)

---

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
ml	1374	+1	1373

async chunks size

id	value	diff	baseline
ml	8.2MB	+816.0B	8.2MB

page load bundle size

id	value	diff	baseline
ml	583.7KB	+7.4KB	576.4KB

History

• 💔 Build #69720 failed 3c21d70
• 💔 Build #68001 failed 07df1d8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream