Change response for Saved Objects share/unshare operations #74995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jportner
added
v8.0.0
release_note:skip
legrego
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
I intentionally left the external APIs unchanged; these will still return an empty HTTP 204 result. My reasoning is that external consumers do not need this information and it would require several changes to integration tests. We only need this change to support an internal consumer (audit logging).
I was initially going to push back on this because we'd be missing the runtime guarantees that we're redacting the namespaces properly, but we do have API tests to verify that we get an empty response back at the API level.
So tl;dr LGTM!
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74989.
Overview
This makes two changes:
SavedObjectsRepository'saddToNamespaces/deleteFromNamespacesmethods to return an object'snamespacesarraySecureSavedObjectsClientWrapperto check privileges and filter (redact) any namespaces that the user is not authorized to viewI intentionally left the external APIs unchanged; these will still return an empty HTTP 204 result. My reasoning is that external consumers do not need this information and it would require several changes to integration tests. We only need this change to support an internal consumer (audit logging).