[SIEM] Fixes timeline local storage test #75123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
MadameSheema
requested review from
patrykkopycinski,
cnasikas,
XavierM and
stephmilovic
MadameSheema
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
andrew-goldstein
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Thanks @MadameSheema!
Tested locally by focusing the timeline_local_storage.spec.ts spec, and running node x-pack/plugins/security_solution/scripts/loop_cypress_tests.js 10 to test for flakeyness
LGTM 🚀
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Aug 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MadameSheema
added a commit
that referenced
this pull request
Aug 20, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are fixing the timeline local storage cypress test.
After investigating a bit looked like the test was failing because Cypress was not performing correctly the click on the delete button of the header. Click on the header first, makes the delete button visible and now the click works without any problem solving the issue.